Opened 3 months ago

Closed 3 months ago

#29553 closed defect (fixed)

pre-commit hook gives a warning when there are no changes files, when source files aren't where expected, and doesn't exit.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: asn-merge
Cc: rl1987 Actual Points:
Parent ID: Points: .1
Reviewer: dgoulet Sponsor:

Description (last modified by nickm)

Problem 1:

Traceback (most recent call last):
  File "scripts/maint/lintChanges.py", line 111, in <module>
    if lintfile(fname):
  File "scripts/maint/lintChanges.py", line 53, in lintfile
    with open(fname) as f:
IOError: [Errno 2] No such file or directory: './changes/*'
On branch release-0.3.5
Your branch is up to date with 'origin/release-0.3.5'.

Problem 2: The script lets me commit anyway.

Problem 3: It doesn't run checkSpace.pl on the right locations for our pre-0.3.5 source layout.

Child Tickets

Change History (5)

comment:1 Changed 3 months ago by nickm

Description: modified (diff)
Summary: pre-commit hook gives a warning when there are no changes files,pre-commit hook gives a warning when there are no changes files, when source files aren't where expected, and doesn't exit.

comment:2 Changed 3 months ago by nickm

Cc: rl1987 added
Status: assignedneeds_review

See branch ticket29553 with PR at https://github.com/torproject/tor/pull/720 . The branch is based on 0.4.0, but I see no reason to backport.

comment:3 Changed 3 months ago by asn

Reviewer: dgoulet

comment:4 Changed 3 months ago by dgoulet

Keywords: asn-merge added
Status: needs_reviewmerge_ready

comment:5 Changed 3 months ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.