#29575 closed defect (fixed)

Configure Firefox Project to Use New TOPL Dependencies

Reported by: sisbell Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TBA-a3, tbb-8.5-must-alpha, TorBrowserTeam201904R
Cc: igt0, sisbell, sysrqb Actual Points:
Parent ID: #27609 Points:
Reviewer: Sponsor:


Child Tickets

Change History (11)

comment:1 Changed 15 months ago by gk

sisbell: Where are we here? It seems that's the last big chunk to get the whole TOPL related changes tested in a build...

comment:2 Changed 15 months ago by sisbell

I just have one remaining issue involving use of transitive resources. I believe I have a solution. I'll test this out today and then update this ticket with the results.

comment:3 Changed 15 months ago by gk

Keywords: TorBrowserTeam201903 added; TorBrowserTeam201902 removed

Moving remaining tickets to March.

comment:4 Changed 15 months ago by gk

Keywords: tbb-8.5 added

Tickets on our radar for 8.5

comment:5 Changed 15 months ago by sisbell

Initial commit android-0309

Android build is definitely different in how it packages files from the libs directory and how it packages remote dependencies. Generally this difference is OK if we are only using classes and not resources from the libraries. Resources seem to be non-transitive, meaning these resource aren't accessible if more than one hop away.

Given that we use resources from tor-android-service -> orbot -> firefox, then firefox (two hops) complains about missing resources, while Orbot (one hop) is fine. If we attempt to directly include tor-android-service in the firefox project, proguard fails because orbot has already included tor-android-services in its own class.jar file (duplicate classes problem).

To solve this problem, orbot project will manually remove tor-android-service classes from its library before packaging and then we can safely included tor-android-service in the firefox project. This solves the missing resources and the duplicate file problem.

comment:6 Changed 15 months ago by sisbell

Status: newneeds_review

comment:7 Changed 15 months ago by gk

Keywords: TorBrowserTeam201903R added; TorBrowserTeam201903 removed

comment:8 Changed 15 months ago by gk

Keywords: tbb-8.5-must added; tbb-8.5 removed

Marking blockers for Tor Browser 8.5.

comment:9 Changed 15 months ago by gk

Keywords: tbb-8.5-must-alpha added; tbb-8.5-must removed

Tickets that block the next 8.5 alpha.

comment:10 Changed 14 months ago by gk

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201903R removed

Moving review tickets to April.

comment:11 Changed 14 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Cherry-picked to master (commit e0c5b567242d1bbfaab5a7aaa8e1b76c992cceb2).

Note: See TracTickets for help on using tickets.