#29579 closed defect (fixed)
Fix typo in projects/tor/build
| Reported by: | boklm | Owned by: | tbb-team |
|---|---|---|---|
| Priority: | Medium | Milestone: | |
| Component: | Applications/Tor Browser | Version: | |
| Severity: | Normal | Keywords: | tbb-rbm, TorBrowserTeam201902R |
| Cc: | Actual Points: | ||
| Parent ID: | Points: | ||
| Reviewer: | Sponsor: |
Description
In projects/tor/build there are two places where we use [% IF ("var/nightly") %] instead of [% IF c("var/nightly") %].
Child Tickets
Change History (3)
comment:1 Changed 10 months ago by
| Keywords: | TorBrowserTeam201902R added; TorBrowserTeam201902 removed |
|---|---|
| Status: | new → needs_review |
comment:2 follow-up: 3 Changed 10 months ago by
| Resolution: | → fixed |
|---|---|
| Status: | needs_review → closed |
Looks good, applied to master (commit 0403da4390f8891a5a082eb6c761cd8710f913ca). So, just to be clear with the typos tor would not have been compiled with rust support for macOS and Windows in nightly builds, right?
comment:3 Changed 10 months ago by
Replying to gk:
Looks good, applied to
master(commit 0403da4390f8891a5a082eb6c761cd8710f913ca). So, just to be clear with the typos tor would not have been compiled with rust support for macOS and Windows in nightly builds, right?
As ("var/nightly") means a list of 1 element, which is always true, the typo caused the lines to be included in all builds. So we have been setting the TOR_RUST_TARGET environment variable in alpha builds, which was probably ignored as we didn't enable rust in the configure options.
There is a patch for review in branch
bug_29579:https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_29579&id=0403da4390f8891a5a082eb6c761cd8710f913ca