Opened 3 months ago

Closed 2 months ago

#29601 closed defect (fixed)

Drop redundant jobs on Appveyor to speed up builds

Reported by: teor Owned by: teor
Priority: High Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.4-alpha
Severity: Normal Keywords: tor-ci, tor-test, windows
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: catalyst Sponsor:

Description (last modified by teor)

Our Appveyor builds are really slow. We can still get decent coverage if we drop some redundant jobs.

The remaining builds will be:

  • 64-bit Windows Server 2016
  • 32-bit Windows Server 2012 R2

We can also set fast_finish, so the first failed job terminates the build immediately.

Child Tickets

Change History (7)

comment:1 Changed 3 months ago by teor

Status: assignedneeds_review

Please see my 0.3.5 pull request:
https://github.com/torproject/tor/pull/733

I also set fast_finish, so that failing jobs fail the entire build immediately.

comment:2 Changed 3 months ago by teor

I worked out how to cut it down to 2 jobs, and force-pushed the changes.

comment:3 Changed 3 months ago by teor

Description: modified (diff)
Summary: Drop the oldest Windows 32-bit build on Appveyor to speed up buildsDrop redundant jobs on Appveyor to speed up builds

Fix description.

comment:4 Changed 3 months ago by dgoulet

Reviewer: catalyst

comment:5 Changed 3 months ago by catalyst

Status: needs_reviewmerge_ready

Thanks! Patch looks good by visual inspection. I agree with the strategy in the patch. I confirmed that the patch does what it claims to do by looking at the appveyor build logs.

comment:6 Changed 2 months ago by nickm

Milestone: Tor: 0.4.1.x-finalTor: 0.3.5.x-final

LGTM; I have merged to 0.4.0 and later. Teor, please feel free to backport.

comment:7 Changed 2 months ago by teor

Resolution: fixed
Status: merge_readyclosed

Merged to 0.3.5 and later.

Thanks everyone - we'll have faster builds now!

Note: See TracTickets for help on using tickets.