Opened 18 months ago

Closed 12 months ago

Last modified 12 months ago

#29611 closed enhancement (wontfix)

Work around lack of app.update.enabled pref in Firefox 63+

Reported by: dcf Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: meek, moat, tbb-update, ff68-esr, TorBrowserTeam201908R
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor44-can

Description

Firefox 63 removes the app.update.enabled pref that we used to prevent the meek and Moat profiles from downloading their own updates (#14203).
https://bugzilla.mozilla.org/show_bug.cgi?id=1420514

As far as I can tell, there isn't a replacement for the pref. The attached patch works around it by setting other prefs:

user_pref("app.update.interval", 999999999); // don't check for updates
user_pref("app.update.auto", false); // if downloaded, don't automatically install
user_pref("app.update.doorhanger", false); // don't show an update notice in the UI

I noticed this while testing with a newer Firefox in #28168. I tested setting these prefs in a Tor Browser 8.0.6, and they didn't have any harmful effect.

Child Tickets

Attachments (2)

0001-Bug-29611-New-way-to-disable-updates-in-meek-Moat-pr.patch (1.6 KB) - added by dcf 18 months ago.
0001-Bug-29611-New-way-to-disable-updates-in-meek-Moat-pr.2.patch (1.7 KB) - added by dcf 17 months ago.
Adds app.update.checkInstallTime=false

Download all attachments as: .zip

Change History (13)

comment:1 Changed 18 months ago by dcf

Status: assignedneeds_review

comment:2 Changed 18 months ago by gk

Cc: mcs brade added
Keywords: tbb-update ff68-esr added

dcf: Is there any reason to have this merged into Tor Browser based on ESR 60? Otherwise I'd set the review flag to a month where we likely pick up patches for the esr68 transition and have us looking over it then.

comment:3 in reply to:  2 Changed 18 months ago by dcf

Replying to gk:

dcf: Is there any reason to have this merged into Tor Browser based on ESR 60? Otherwise I'd set the review flag to a month where we likely pick up patches for the esr68 transition and have us looking over it then.

It's not needed for ESR 60. In ESR 68 it's possible to delete the app.update.enabled line completely.

comment:4 Changed 18 months ago by gk

Keywords: TorBrowserTeam201907R added

comment:5 Changed 18 months ago by mcs

After we fix #29445, another approach would be to use an enterprise policy to disable updates. I haven't tried it, but I assume it works. See: https://support.mozilla.org/en-US/questions/1232918#answer-1176526

Changed 17 months ago by dcf

Adds app.update.checkInstallTime=false

comment:6 Changed 17 months ago by dcf

Experimenting with Firefox 67.0b6 shows that an additional pref is required to prevent an update check on the very first execution. attachment:0001-Bug-29611-New-way-to-disable-updates-in-meek-Moat-pr.2.patch sets app.update.checkInstallTime=false.

app.update.checkInstallTime and app.update.checkInstallTime.days control update checks that are based on time passed since the build ID, rather than time passed since the last check. References:

https://dxr.mozilla.org/mozilla-central/rev/c06dfc552c647a6ce96f35cd84c32a589dc85608/browser/app/profile/firefox.js#81-83
https://dxr.mozilla.org/mozilla-central/rev/c06dfc552c647a6ce96f35cd84c32a589dc85608/browser/components/BrowserGlue.jsm#1053-1074

comment:7 Changed 13 months ago by gk

Keywords: TorBrowserTeam201908R added; TorBrowserTeam201907R removed

No July any longer.

comment:8 Changed 12 months ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:9 Changed 12 months ago by gk

Will probably get fixed by #29430 in the sense that the profile and extension are not needed anymore then.

Last edited 12 months ago by gk (previous) (diff)

comment:10 in reply to:  9 Changed 12 months ago by gk

Resolution: wontfix
Status: needs_reviewclosed

Replying to gk:

Will probably get fixed by #29430 in the sense that the profile and extension are not needed anymore then.

Done.

Note: See TracTickets for help on using tickets.