Opened 7 months ago

Closed 5 months ago

#29613 closed defect (implemented)

Make relays into exits when ExitRelay is auto and IPv6Exit is 1

Reported by: teor Owned by: neel
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version: Tor: 0.3.5.1-alpha
Severity: Normal Keywords: ipv6, 041-proposed, tor-relay, tor-exit, reviewer-was-teor-20190422
Cc: neel Actual Points: 0.1
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

In #21530, we made relays exit if ExitRelay is auto, and either:

  • ReducedExitPolicy is 1, or
  • ExitPolicy is set

But a relay operator who sets IPv6Exit to 1 also wants to be an exit.

So we should add IPv6Exit 1 to the options that activate exits when ExitRelay is auto. We should also update the documentation (see #29612).

Child Tickets

Change History (14)

comment:1 Changed 7 months ago by teor

Keywords: tor-relay tor-exit added

comment:2 Changed 7 months ago by neel

Owner: set to neel
Status: newassigned

comment:3 Changed 7 months ago by neel

Cc: neel added

comment:4 Changed 5 months ago by neel

Status: assignedneeds_review

comment:5 Changed 5 months ago by asn

Reviewer: teor

comment:6 Changed 5 months ago by teor

Actual Points: 0.1
Milestone: Tor: unspecifiedTor: 0.4.1.x-final
Status: needs_reviewneeds_revision

This looks good, but we could do a bit of refactoring to make the code simpler.
And we need to update the man page.
See my comments on the pull request.

comment:7 Changed 5 months ago by neel

Status: needs_revisionneeds_review

Made the changes and pushed them.

comment:8 Changed 5 months ago by cypherpunks

hopefully this will let appear more nodes with exit flag

comment:9 Changed 5 months ago by teor

Status: needs_reviewneeds_revision

Hi neel,

On the pull request, I also asked:

Please update the man page entries for ExitRely and IPv6Exit.

Thanks!

comment:10 Changed 5 months ago by neel

Status: needs_revisionneeds_review

Man page updated and pushed.

comment:11 Changed 5 months ago by teor

Status: needs_reviewneeds_revision

Just some grammar fixes, feel free to put this ticket in merge_ready after you've applied them.

comment:12 Changed 5 months ago by neel

Status: needs_revisionmerge_ready

Made the changes and pushed them.

comment:13 Changed 5 months ago by teor

Keywords: reviewer-was-teor-20190422 added
Reviewer: teor

If these tickets go back in to needs_review, and I am on leave, they will need another reviewer.

comment:14 Changed 5 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

LGTM; merged.

Note: See TracTickets for help on using tickets.