Opened 8 months ago

Closed 8 months ago

#29618 closed defect (fixed)

Chutney doesn't use python3 if a "python2" binary exists, and fails if it uses python3 anyway.

Reported by: nickm Owned by: nickm
Priority: Very High Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords:
Cc: teor Actual Points: .3
Parent ID: Points:
Reviewer: Sponsor: Sponsor19

Description

In the "chutney" shell script, the search list for python binaries is:

binaries="python2 python"

This means that even if python3 is installed as "python", chutney will use python2 instead.

This mistake has led us to accumulate a bunch of python3 incompatibilities.

Child Tickets

TicketStatusOwnerSummaryComponent
#16904closedcypherpunkschutney fails to work with python3Core Tor/Chutney

Change History (12)

comment:1 Changed 8 months ago by nickm

Status: newneeds_review

See branch bug29618

comment:2 Changed 8 months ago by nickm

Actual Points: .3
Sponsor: Sponsor19

comment:3 in reply to:  description Changed 8 months ago by teor

Replying to nickm:

This mistake has led us to accumulate a bunch of python3 incompatibilities.

Chutney never worked with python3, so we deliberately put python2 first in #16902, until #16904 and #14332 were completed. But they were never completed.

We can close them when this ticket closes.

comment:4 Changed 8 months ago by teor

Status: needs_reviewneeds_revision

I wonder about commit 49087abb2ab:
Should we modify mkdir_p() rather than all its callers that use a mode?

Would you mind opening a pull request for future tickets?

comment:5 Changed 8 months ago by nickm

Status: needs_revisionneeds_review

Should we modify mkdir_p() rather than all its callers that use a mode?

I had considered that, but the logic for reimplementing makedirs from scratch is a little error prone. How about a wrapper instead, as in d07859bb532faff007fd9ddf795bf31d35b32c44?

Would you mind opening a pull request for future tickets?

Okay, PR at https://github.com/torproject/chutney/pull/4

Last edited 8 months ago by nickm (previous) (diff)

comment:6 Changed 8 months ago by teor

Status: needs_reviewmerge_ready

Thanks, looks fine to me.

Let's try to merge a minimal set of tickets before CI, then CI, then the other tickets?

comment:7 Changed 8 months ago by nickm

Let's try to merge a minimal set of tickets before CI, then CI, then the other tickets?

That's fine with me in principle, but I don't know which set you consider minimal?

comment:8 in reply to:  7 Changed 8 months ago by teor

Replying to nickm:

Let's try to merge a minimal set of tickets before CI, then CI, then the other tickets?

That's fine with me in principle, but I don't know which set you consider minimal?

Oh right, now I understand what you're asking.

This ticket is required for chutney's CI to use python 3, so let's merge it before the CI ticket.

comment:9 Changed 8 months ago by teor

Owner: set to nickm
Status: merge_readyassigned

comment:10 Changed 8 months ago by teor

Status: assignedmerge_ready

comment:11 Changed 8 months ago by nickm

Okay, I've merged this to master.

comment:12 Changed 8 months ago by nickm

Resolution: fixed
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.