Opened 9 months ago

Closed 8 months ago

#29631 closed defect (fixed)

protover: Rust missing Padding value in translate_to_rust()

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rust, protover, fast-fix, nickm-merge
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: ahf Sponsor:

Description

Noticed that when I was adding the protover support in #26288.

Child Tickets

Change History (7)

comment:1 Changed 9 months ago by dgoulet

Keywords: fast-fix added
Status: assignedneeds_review

PR: https://github.com/torproject/tor/pull/751
Branch: ticket29631_041_01

comment:2 Changed 9 months ago by dgoulet

Reviewer: nickm

comment:3 Changed 9 months ago by asn

Reviewer: nickmahf

comment:4 Changed 9 months ago by ahf

Status: needs_reviewmerge_ready

Looks good.

comment:5 Changed 8 months ago by nickm

Is this a backport candidate? PRT_PADDING was first defined in 0.4.0.

comment:6 in reply to:  5 Changed 8 months ago by dgoulet

Keywords: nickm-merge added

Replying to nickm:

Is this a backport candidate? PRT_PADDING was first defined in 0.4.0.

Oh! Damn I thought it was 0.4.1... So yes, seems we support Rust for last two stables. I've pushed a changes file to a 040 branch for backport: ticket29631_040_01

comment:7 Changed 8 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Thanks! Merged that one to 0.4.0 and forward.

Note: See TracTickets for help on using tickets.