Opened 7 years ago

Closed 7 years ago

#2965 closed enhancement (implemented)

Vidalia parameter handling improvements (includes PATCH)

Reported by: jrklein Owned by: chiiph
Priority: Medium Milestone: Vidalia: 0.2.13
Component: Archived/Vidalia Version: Vidalia 0.2.10
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Vidalia ignores parameters and values that are separated by an equal sign.
(ie: Vidalia --datadir=data --logfile=log)

Attached patch updates parseArguments() to support keys and values separated by equal sign.

Vidalia does not reject parameters that should include a value.
(ie: Vidalia --datadir --logfile)

Attached patch calls argNeedsValue() from validateArguments() to determine if value is required. Vidalia notifies user if required parameter value is missing.

NOTE: validateArguments() was static, so could not call argNeedsValue(). No longer static. If function needs to be static, could pass an instance of Vidalia as a function parameter instead.

Child Tickets

Attachments (1)

tor-2965-vidalia-parameter-handling.patch (2.8 KB) - added by jrklein 7 years ago.
Vidalia: Improved Parameter Handling

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by jrklein

Vidalia: Improved Parameter Handling

comment:1 Changed 7 years ago by chiiph

Milestone: Vidalia: 0.2.13

comment:2 Changed 7 years ago by chiiph

Resolution: implemented
Status: newclosed

This is in the repo in commit d532d66ed34a837b0f3950f5a7a2bc889b08a0ce.

This change will be available in 0.2.13 and 0.3.1-alpha. Thanks for the patch Jason! Sorry this took so long.

Note: See TracTickets for help on using tickets.