Opened 7 weeks ago

Closed 7 weeks ago

Last modified 6 weeks ago

#29666 closed enhancement (implemented)

Update to March GeoIP2 database

Reported by: karsten Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client, tor-relay, 029-backport, 032-backport, 033-backport, 035-must, 035-rc-must, 034-backport, 035-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

My geoip-2019-03-04 branch contains the updated geoip and geoip6 files with IPv4 and IPv6 ranges and is supposed to be merged into maint-0.2.9 and other branches that are still maintained.

Child Tickets

Change History (5)

comment:1 Changed 7 weeks ago by karsten

Status: newneeds_review

comment:2 Changed 7 weeks ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merging to 0.2.9 and forward. (Teor, please let me know if you want to do this as a two-phase thing in the future: In the past, I've treated these branches as an automatic merge, after checking that they touch the right files)

comment:3 in reply to:  2 Changed 6 weeks ago by teor

Replying to nickm:

Merging to 0.2.9 and forward. (Teor, please let me know if you want to do this as a two-phase thing in the future: In the past, I've treated these branches as an automatic merge, after checking that they touch the right files)

I don't think we have unit tests that load the geoip file, so it really doesn't matter at the moment.

But once we do #29701 and #29702, we'll want to do 2-phase commits, so we catch broken GeoIP files when they break the unit tests on master.

comment:4 Changed 6 weeks ago by teor

I am also happy to do 2-phase whenever you want to start doing it.
It's good practice to do everything consistently?

comment:5 Changed 6 weeks ago by teor

Milestone: Tor: 0.4.0.x-finalTor: 0.2.9.x-final

These GeoIP changes were all backported to 0.2.9 (or earlier).

Note: See TracTickets for help on using tickets.