Opened 7 months ago

Closed 6 months ago

#29675 closed defect (fixed)

Nightly build should fail if "make fetch" fails

Reported by: boklm Owned by: cypherpunks
Priority: Medium Milestone:
Component: Applications/Quality Assurance and Testing Version:
Severity: Normal Keywords: TorBrowserTeam201903
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We run make fetch during the nightly builds to fetch the latest commits before starting the build. However we ignore the exit code from make fetch, so if there an error in the middle of fetching, then we build with old commits.

Instead we should make the build fail if there was an error in make fetch, so we can know there was something wrong and can fix it.

Child Tickets

Change History (1)

comment:1 Changed 6 months ago by boklm

Resolution: fixed
Status: newclosed

This is done by commits dc49721feb8f2c3cb48079e4197cf4bfff875538 and 9283635ace22c3a7f629b5bc60e8fec0af4dc13c in tor-browser-bundle-testsuite.git and 93a114bcb49f72c7131344cc67e47ce90bd81c77 in tor-browser-build.git.

Note: See TracTickets for help on using tickets.