Opened 15 months ago

Closed 8 weeks ago

#29686 closed defect (fixed)

filenames conflict on case-insensitive filesystems

Reported by: catalyst Owned by: phw
Priority: Medium Milestone:
Component: Circumvention/BridgeDB Version:
Severity: Normal Keywords: ex-sponsor-19, s30-o24a4
Cc: cohosh Actual Points: 0.7
Parent ID: #31281 Points: 0.5
Reviewer: cohosh Sponsor: Sponsor30-can

Description

Trying to clone the bridgedb repository on macOS on a case-insensitive filesystem results in:

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'bridgedb/Bridges.py'
  'bridgedb/bridges.py'
  'bridgedb/test/test_Bridges.py'
  'bridgedb/test/test_bridges.py'
  'doc/sphinx/source/bridgedb.Bridges.rst'
  'doc/sphinx/source/bridgedb.bridges.rst'

We should rename stuff so the code is easier to work on in a case-insensitive filesystem.

Child Tickets

Change History (7)

comment:1 Changed 12 months ago by gaba

Keywords: ex-sponsor-19 added

Adding the keyword to mark everything that didn't fit into the time for sponsor 19.

comment:2 Changed 12 months ago by phw

Sponsor: Sponsor19-canSponsor30-can

Moving from Sponsor 19 to Sponsor 30.

comment:3 Changed 2 months ago by phw

Keywords: s30-o24a4 added
Owner: changed from sysrqb to phw
Parent ID: #31281
Points: 0.5
Status: newassigned

comment:4 Changed 2 months ago by phw

Status: assignedneeds_review

Here's a branch that fixes this issue.

comment:5 Changed 8 weeks ago by cohosh

Reviewer: cohosh

comment:6 Changed 8 weeks ago by cohosh

Status: needs_reviewmerge_ready

Only one minor comment:

  • It looks like the Bridge class here should be in bridgedb.bridges.Bridge? There's not Bridge class in bridgedb.bridgerings.

Otherwise, this looks good to me!

comment:7 in reply to:  6 Changed 8 weeks ago by phw

Actual Points: 0.7
Resolution: fixed
Status: merge_readyclosed

Replying to cohosh:

Only one minor comment:

  • It looks like the Bridge class here should be in bridgedb.bridges.Bridge? There's not Bridge class in bridgedb.bridgerings.

Otherwise, this looks good to me!


Oh, good catch! I fixed the issue and merged branch defect/29686.

This fix took a bit longer than expected because it broke a unit test that seems to have relied on the alphabetic ordering of unit tests – which we changed in this patch. Giving BridgeDB a bit more time to start should have fixed this issue.

Note: See TracTickets for help on using tickets.