Opened 9 months ago

Closed 8 months ago

#29691 closed defect (fixed)

Builds from master fail on Jenkins mingw builder

Reported by: harig Owned by: ahf
Priority: High Milestone: Tor: 0.4.0.x-final
Component: Internal Services/Service - jenkins Version: Tor: 0.4.0.1-alpha
Severity: Normal Keywords: tor-ci, tor-jenkins, 040-must?
Cc: nickm, weasel Actual Points: 0.2
Parent ID: Points: 0.5
Reviewer: weasel Sponsor:

Description

On https://jenkins.torproject.org/view/tor/ the builds from git master for tor-ci-mingwcross-master builder are failing for a long time (Last successful build (# 2226), 2 mo 20 days ago )

A failing build log e.g. https://jenkins.torproject.org/view/tor/job/tor-ci-mingwcross-master/lastCompletedBuild/ARCHITECTURE=amd64,SUITE=stretch/consoleFull#-16059184715da2eb1d-1267-4376-8b22-f5f143383dc7

21:28:05 + cp src/test/test-child.exe /srv/jenkins-workspace/workspace/tor-ci-mingwcross-master/ARCHITECTURE/amd64/SUITE/stretch/RESULT/bin/
21:28:05 cp: cannot stat 'src/test/test-child.exe': No such file or directory
21:28:05 + rc=1

There are no usable artifacts as a result, for those who wish to use them. Aside, no artifacts are kept on Appveyor too.

Child Tickets

Change History (11)

comment:1 in reply to:  description Changed 9 months ago by teor

Keywords: tor-ci tor-jenkins added
Version: Tor: unspecified

Hi, thanks for this bug report!

Replying to harig:

A failing build log e.g. https://jenkins.torproject.org/view/tor/job/tor-ci-mingwcross-master/lastCompletedBuild/ARCHITECTURE=amd64,SUITE=stretch/consoleFull#-16059184715da2eb1d-1267-4376-8b22-f5f143383dc7

21:28:05 + cp src/test/test-child.exe /srv/jenkins-workspace/workspace/tor-ci-mingwcross-master/ARCHITECTURE/amd64/SUITE/stretch/RESULT/bin/
21:28:05 cp: cannot stat 'src/test/test-child.exe': No such file or directory
21:28:05 + rc=1

test-child.exe was replaced by test-process.exe in #28179 in 0.4.0.1-alpha.

So this appears to be a jenkins bug.

There are no usable artifacts as a result, for those who wish to use them. Aside, no artifacts are kept on Appveyor too.

We only keep logs on Appveyor. I guess we could keep binaries in a separate archive, but I'm not sure how easy they'd be to access.

comment:2 Changed 9 months ago by harig

I'm not sure how easy they'd be to access.

If the binaries resulting from a job in Appveyor are kept they can be downloaded from the Artifacts section (e.g. https://ci.appveyor.com/project/torproject/tor/build/job/c3ml4a3222ioq1tj/artifacts)

comment:3 in reply to:  2 Changed 9 months ago by teor

Replying to harig:

I'm not sure how easy they'd be to access.

If the binaries resulting from a job in Appveyor are kept they can be downloaded from the Artifacts section (e.g. https://ci.appveyor.com/project/torproject/tor/build/job/c3ml4a3222ioq1tj/artifacts)

Sorry, I wasn't very clear.

I'm not sure how easy it would be to access the Appveyor binaries from a script or some other automated process, like people access nightly builds of other Tor binaries from Jenkins. But if you have some idea of how we could make it work, feel free to open another ticket with a patch to the Tor master branch.

comment:4 Changed 8 months ago by teor

Component: Internal Services/Service - jenkinsCore Tor/Tor
Milestone: Tor: 0.4.0.x-final
Owner: changed from weasel to ahf
Points: 0.5
Status: newassigned
Version: Tor: 0.4.0.1-alpha

This bug is still failing jenkins. We need to fix the jenkins scripts, or we will not have any 0.4.0 windows binaries.

I think ahf is the best person to fix this jenkins bug.

When there's a patch, we can put it back in the jenkins component so that a service admin can apply it.

comment:5 Changed 8 months ago by nickm

Keywords: 040-must? added
Priority: MediumHigh

comment:6 Changed 8 months ago by ahf

Actual Points: 0.2
Cc: weasel added
Reviewer: weasel

Added patch to my branch 'bugs/29691' on https://github.com/ahf/tor-jenkins-tools.git (forked from https://git.torproject.org/project/jenkins/tools.git) - available via Github's web UI at: https://github.com/ahf/tor-jenkins-tools/tree/bugs/29691

The commit can be seen here: https://github.com/ahf/tor-jenkins-tools/commit/76a20850e7c62475ea603069de56c50216245050.patch

I think weasel will be the best person to review this.

comment:7 Changed 8 months ago by ahf

Status: assignedneeds_review

comment:8 Changed 8 months ago by teor

Component: Core Tor/TorInternal Services/Service - jenkins

This ticket now has a patch, so it belongs in the Jenkins component.
(It can go through the Jenkins review and merge process.)

comment:9 Changed 8 months ago by weasel

thanks, merged

comment:10 Changed 8 months ago by weasel

This breaks builds on all versions up to, including, 0.3.5.x. Fixing.

comment:11 Changed 8 months ago by weasel

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.