Opened 9 months ago

Closed 7 months ago

#29696 closed defect (fixed)

Fix platform dependencies in data-processing modules

Reported by: karsten Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Statistics Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While working on integration tests for data-processing modules (#29425), I noticed that some of the output is platform dependent.

I'm going to post a branch that fixes these platform dependencies shortly.

Child Tickets

Change History (3)

comment:1 Changed 9 months ago by karsten

Status: assignedneeds_review

Please review my metrics-web task-29696 branch which can be tested using my metrics-test task-29696 branch.

comment:2 Changed 7 months ago by irl

Status: needs_reviewmerge_ready

I have not been able to test this yet with metrics-test, but the commits make sense.

I think we can merge this. I'll leave it to you to decide if you want to wait for me to run metrics-test though.

comment:3 Changed 7 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Thanks for the review! I think it's sufficient if you looked at the code. I already tested the branch using metrics-test, so that should be fine. I merged the changes to master, made a backup of the tordir database, and deployed the changes. We'll see in the next days if things fall apart, but I'm optimistic that they don't. Closing. Thanks!

Note: See TracTickets for help on using tickets.