Stop using configs from the local tor install when we launch tor for tests

[teor]

We should stop using paths in /usr when we're launching tor for build tests.

We don't get full logs for all the tor processes we launch, but these scripts launch tor, so they're probably affected:

• test_rebind.sh
• test_key_expiration.sh
• test_keygen.sh
• test_zero_length_keys.sh

test-network.sh is also affected, but we'll deal with that in chutney in #29701.

For example, on my machine, test_rebind.sh does:

2019-03-05 11:00:11.573 Tor logged: "Mar 05 11:00:11.571 [notice] Configuration file "/usr/local/etc/tor/torrc" not present, using reasonable defaults.", waiting for "Opened Control listener on"
2019-03-05 11:00:11.596 Tor logged: "Mar 05 11:00:11.591 [notice] Parsing GEOIP IPv4 file /usr/local/share/tor/geoip.", waiting for "Opened Socks listener"
2019-03-05 11:00:11.899 Tor logged: "Mar 05 11:00:11.899 [notice] Parsing GEOIP IPv6 file /usr/local/share/tor/geoip6.", waiting for "Opened Socks listener"

[rl1987]

test_keygen.sh does the following:

 85 touch "${DATA_DIR}/empty_torrc"                                                 
 86                                                                                 
 87 QUIETLY="--hush"                                                                
 88 SILENTLY="--quiet"                                                              
 89 TOR="${TOR_BINARY} ${QUIETLY} --DisableNetwork 1 --ShutdownWaitLength 0 --ORPort 12345 --ExitRelay 0 -f ${DATA_DIR}/empty_torrc"

[rl1987]

So does test_key_expiration.sh; test_zero_length_keys.sh launches zero_length_keys.sh, which does this as well.

[rl1987]

Doing the same in test_rebind.py: ​https://github.com/torproject/tor/pull/793

[teor]

Remove Mike as reviewer, because he's overloaded.
We'll work out what to do with these tickets in the weekly meeting.

[nickm]

LGTM. I've opened #30102 to make sure that we don't reintroduce this kind of bug.

[nickm]

FWIW though, I think we should backport this as far as 0.3.5. So let's rebase before merging.

[teor]

Rebased to 0.3.5 as ​https://github.com/torproject/tor/pull/924

Waiting for CI.

[teor]

These changes are a good start, but they don't resolve the original issue:

$ make check
$ grep usr src/test/test_rebind.sh.log 
2019-04-10 19:09:45.714 Tor logged: "Apr 10 19:09:45.709 [notice] Parsing GEOIP IPv4 file /usr/local/share/tor/geoip.", waiting for "Opened Socks listener"
2019-04-10 19:09:46.128 Tor logged: "Apr 10 19:09:46.127 [notice] Parsing GEOIP IPv6 file /usr/local/share/tor/geoip6.", waiting for "Opened Socks listener"

I think we'll either need to change Tor's default share path at compile-time:

./configure --datarootdir=src/config

Or explicitly supply GeoIP and GeoIPv6 config lines in the defaults or user torrcs. (Or both, so that we catch future issues like this.)

We might also want to set configure --prefix to an empty directory, to catch future issues like this.

We also forgot to use an empty file for the defaults-torrc, so I added a commit to do that in all the scripts.

Whatever we do, we should make sure we fix this issue in Travis and Appveyor.

[teor]

My extra commit is in:
​https://github.com/torproject/tor/pull/924

[nickm]

PR 924 above looks good to me. I have confirmed that it works with all kinds of junk in my torrc, the system torrc, and the system torrc-defaults.

I have opened #30526 to handle the geoip issue. I think we should merge this branch as it is, and backport to 0.3.5, since it is undesirable to launch Tor with a user's configuration for testing purposes.

[asn]

merged to 040 and onwards.

[nickm]

Marking for 035 backport

[teor]

Backported to 0.3.5.