Changes between Initial Version and Version 1 of Ticket #29705, comment 6


Ignore:
Timestamp:
Sep 27, 2019, 2:13:39 AM (7 weeks ago)
Author:
willbarr
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #29705, comment 6

    initial v1  
    77I think the risks of enabling brotli over http and breaking onion sites is less important than it’s advantages when supported.
    88
    9 There are two ways to enable brotli support, 1) just enable it on all http requests including non-onions 2) creating a “potentialy trustworthy” context, put onion sites there and enable brotli there.
     9There are two ways to enable brotli support, 1) just enable it on all http requests including non-onions 2) create a “potentialy trustworthy” context, put onion sites there and enable brotli there.
    1010
    1111The first approach will be as simple as adding br here. https://gitweb.torproject.org/tor-browser.git/tree/modules/libpref/init/all.js#n1754
    1212
    13 This is presumed to break certain legacy sites. However I haven’t had any problems when I tested this on various sites.
     13This is presumed to break certain legacy sites. However I haven’t had any problems when I tested this on various legacy sites.
    1414
    1515The second approach is rather hard, and it deviates a lot from upstream firefox code base. I’ve found an example implementation, which enables brotli on localhost by putting them into a “potentially trustworthy” context”.