Opened 5 months ago

Closed 3 months ago

#29715 closed defect (fixed)

Change documentation about RouterStatusEntryV3 bandwidth to specify that unit is kilobytes

Reported by: juga Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Child Tickets

Change History (4)

comment:1 Changed 5 months ago by juga

It should also say kilobytes for Measured.

comment:2 Changed 5 months ago by teor

Description: modified (diff)

Fix url

comment:3 Changed 5 months ago by teor

Stem is not wrong.
But it would be more helpful if it said "arbitrary units (currently kilobytes per second)".

Here are the details:

dir-spec says that weights are in arbitrary units. And it says that the current design uses kilobytes per second, re-weighted by bandwidth measurements:
https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n2381

bandwidth-file-spec says kilobytes per second, because it specifies the current design:
https://gitweb.torproject.org/torspec.git/tree/bandwidth-file-spec.txt#n361

Relays' self-reported bandwidths are in bytes per second, so tor scales them to kilobytes per second:
https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n432

Torflow and sbws:

  • start with bytes and kilobytes per second,
  • scale everything to bytes
  • re-weight by the ratio of the node to the network average to get re-weighted bytes per second, and then
  • scale to re-weighted kilobytes per second.

comment:4 Changed 3 months ago by atagar

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.