Opened 9 months ago

Closed 9 months ago

#29722 closed defect (implemented)

Document that authorities are not measured

Reported by: juga Owned by: juga
Priority: Medium Milestone: sbws: 1.1.x-final
Component: Core Tor/sbws Version: sbws: 1.0.5
Severity: Normal Keywords: no-changes-version, sbws-docs, easy
Cc: juga Actual Points:
Parent ID: Points: 1
Reviewer: cohosh Sponsor:

Description


Child Tickets

Change History (10)

comment:1 Changed 9 months ago by juga

Keywords: no-changes-version added

Add keyword to help planify releases/milestones.
Tickets that doesn't imply a change of version are tickets which do not affect the code (docs, tests) and some time of refactors.

comment:2 Changed 9 months ago by juga

Keywords: docs added

Add keyword. docs are tickets that affect to documentation

comment:3 Changed 9 months ago by juga

Owner: set to juga
Status: newassigned

comment:4 Changed 9 months ago by juga

Status: assignedneeds_revision

https://github.com/torproject/sbws/pull/351

In revision since didn't check the generated docs.

comment:5 Changed 9 months ago by juga

Keywords: sbws-docs easy added; docs removed
Status: needs_revisionneeds_review

Changes only affect documentation

comment:6 Changed 9 months ago by asn

Reviewer: cohosh

comment:7 Changed 9 months ago by cohosh

Status: needs_reviewneeds_revision

It looks good! Here are some minor grammatical changes (but it makes sense as it is):

  • ...by creating a two hops circuit with the relay to measure, download data from a destination Web Server and store the measurements. --> ...by creating a two hops circuit with the relay. It then measures the bandwidth by downloading data from a destination Web Server and stores the measurements.
  • The generator read the measurements, aggregate, filter and scales them --> The generator reads the measurements, aggregates, filters, and scales them

I'll put this is in needs_revision but leave it up to you to decide whether you want to make the changes.

One question: the ticket summary says the scanner does not measure directory authorities by default. Does that mean there is an option to measure them?

comment:8 in reply to:  7 Changed 9 months ago by juga

Status: needs_revisionmerge_ready

Replying to cohosh:

It looks good! Here are some minor grammatical changes (but it makes sense as it is):

  • ...by creating a two hops circuit with the relay to measure, download data from a destination Web Server and store the measurements. --> ...by creating a two hops circuit with the relay. It then measures the bandwidth by downloading data from a destination Web Server and stores the measurements.
  • The generator read the measurements, aggregate, filter and scales them --> The generator reads the measurements, aggregates, filters, and scales them

I'll put this is in needs_revision but leave it up to you to decide whether you want to make the changes.

Pushed a fixup with your suggestion.
Putting in merge_ready since i don't think we need other iteration.

comment:9 in reply to:  7 Changed 9 months ago by juga

Summary: Document that authorities are not measured by defaultDocument that authorities are not measured

Replying to cohosh:

One question: the ticket summary says the scanner does not measure directory authorities by default. Does that mean there is an option to measure them?

Good point :), changing title cause we don't have the option and don't think we will add it any time soon (though would be very easy)

comment:10 Changed 9 months ago by juga

Resolution: implemented
Status: merge_readyclosed

Merged.

Note: See TracTickets for help on using tickets.