Opened 2 months ago

Closed 2 months ago

#29740 closed defect (fixed)

Fix memory leaks in shared random unit tests: simple version

Reported by: teor Owned by: teor
Priority: Very High Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.9.1-alpha
Severity: Major Keywords: tor-ci, tor-test, memory-management, 029-backport, 034-backport, 035-backport, 040-backport, nickm-merge, dgoulet-merge
Cc: Actual Points: 0.3
Parent ID: Points: 0.1
Reviewer: asn Sponsor:

Description

Please merge https://github.com/torproject/tor/pull/774 to the mainline branches.
I'll merge to to 0.2.9 and later after the mainline CI passes.

Child Tickets

Change History (10)

comment:1 Changed 2 months ago by teor

Reviewer: asn
Status: assignedmerge_ready

asn reviewed in #29706.

comment:2 Changed 2 months ago by teor

Keywords: nickm-merge dgoulet-merge added

comment:3 Changed 2 months ago by teor

Priority: HighVery High

comment:4 Changed 2 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

#29706 is closed; closing this

comment:5 Changed 2 months ago by teor

Milestone: Tor: 0.4.1.x-finalTor: 0.3.5.x-final
Resolution: fixed
Status: closedreopened

#29706 is not closed. And this change should be backported to 0.2.9 and later.
Putting in 0.3.5, because #29706 was merged to 0.4.0 and later.

comment:6 Changed 2 months ago by teor

Actual Points: 0.10.3
Milestone: Tor: 0.3.5.x-finalTor: 0.4.0.x-final
Parent ID: #29706
Status: reopenedneeds_review

It turns out we need to apply a9c3101 from #29706 to avoid all leaks:
https://trac.torproject.org/projects/tor/ticket/29706#comment:12

The pull requests are:

0.2.9, one commit added:
https://github.com/torproject/tor/pull/774

0.3.4, merged, and one comment commit added:
https://github.com/torproject/tor/pull/801

0.4.0, comments merged, the code changes are already in 0.4.0:
https://github.com/torproject/tor/pull/802

(#29706 is too big to backport, so I'm un-parenting this ticket.)

comment:7 Changed 2 months ago by teor

One appveyor test failed due to #29645. I'm going to relaunch the test to make sure there aren't any more failures.

comment:8 Changed 2 months ago by asn

Status: needs_reviewmerge_ready

LGTM!

comment:9 Changed 2 months ago by nickm

Milestone: Tor: 0.4.0.x-finalTor: 0.3.5.x-final

I've merged PR 802 above into 0.4.0 and forward to get the comment change. Marking for backport.

comment:10 Changed 2 months ago by teor

Milestone: Tor: 0.3.5.x-finalTor: 0.2.9.x-final
Resolution: fixed
Status: merge_readyclosed

Merged to 0.2.9 and 0.3.4 and merged forward.
Merged #29740 and #28656 together.

Note: See TracTickets for help on using tickets.