#29747 closed defect (fixed)

shellcheck errors on the new git scripts

Reported by: asn Owned by: nickm
Priority: High Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: shellcheck maint scripts teor-merge
Cc: Actual Points: .1
Parent ID: Points: 0.3
Reviewer: asn Sponsor:

Description

The scripts added by #29391 are triggering shellcheck errors on travis:
https://travis-ci.org/asn-d6/tor/jobs/505198755#L3149

CI seems to be partially broken because of that.

Child Tickets

Change History (7)

comment:1 Changed 11 months ago by nickm

Owner: set to nickm
Status: newaccepted

comment:2 Changed 11 months ago by nickm

Actual Points: .1
Reviewer: asn
Status: acceptedneeds_review

comment:3 Changed 11 months ago by asn

Resolution: fixed
Status: needs_reviewclosed

LGTM!

comment:5 Changed 11 months ago by asn

Status: closedmerge_ready

ugh wrong button. setting to merge_ready.

comment:6 Changed 10 months ago by nickm

Keywords: teor-merge added

comment:7 Changed 10 months ago by nickm

Milestone: Tor: 0.4.0.x-finalTor: 0.4.1.x-final

comment:8 Changed 10 months ago by teor

Status: merge_readyclosed

Merged to master

Note: See TracTickets for help on using tickets.