Opened 9 months ago

Closed 9 months ago

#29748 closed enhancement (fixed)

Let test-network.sh tolerate some number of failures

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: CI, PTs 029-backport 034-backport 035-backport 040-backport, network-team-roadmap-2019-Q1Q2
Cc: teor Actual Points: .3
Parent ID: #29280 Points: .3
Reviewer: teor Sponsor: Sponsor19

Description

This had been part of #29280, but teor notes correctly that it should be part of Chutney's test-network.sh

Child Tickets

Change History (3)

comment:1 Changed 9 months ago by nickm

Actual Points: .3
Reviewer: teor
Status: assignedneeds_review

See my chutney branch test-network-forgiving-v2, with PR at https://github.com/teor2345/chutney/pull/2 . This branch is based on Teor's chutney-travis-v4 branch so that it can get CI itself. It should get rebased before merging. It also increments the allowed failures in the travis ci to 1.

comment:2 Changed 9 months ago by teor

Points: .3
Status: needs_reviewmerge_ready

Looks good to me. I made some comments, but I worked out the answers myself.

comment:3 Changed 9 months ago by teor

Resolution: fixed
Status: merge_readyclosed

Rebased as my test-network-forgiving-v2-rebased.

CI failed one job on 0.2.9, but the debug run succeeded:
https://travis-ci.org/torproject/chutney/jobs/505547963

We might need to increase the allowed failures for 0.2.9, or put a sleep in between the allow failures tests. I opened #29761 to track the failures, so we can work out what to do here.

Merged to master as 9ef9ccc.

Note: See TracTickets for help on using tickets.