Opened 2 months ago

Closed 2 months ago

Last modified 9 days ago

#29756 closed defect (fixed)

Check for correct header macro guards.

Reported by: nickm Owned by: nickm
Priority: Low Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: catalyst Actual Points: .1
Parent ID: Points: 0.1
Reviewer: cohosh Sponsor: Sponsor31-can

Description

We should probably make sure that our headers all have correct guard macros. When we forget to do this, we usually get sad about it.

Child Tickets

Change History (7)

comment:1 Changed 2 months ago by nickm

Actual Points: .1
Status: assignedneeds_review

comment:2 Changed 2 months ago by catalyst

Cc: catalyst added

comment:3 Changed 2 months ago by asn

Reviewer: catalyst

comment:4 Changed 2 months ago by asn

Reviewer: catalystcohosh

comment:5 Changed 2 months ago by cohosh

Status: needs_reviewmerge_ready

Looks good!

The checkSpace.pl script could use some comments stating that the new addition checks header files for #ifndef/#define pairs. Something along the lines of the # Warn about comments used in other parts of the script.

This is a very quick fix so I'm putting this in merge_ready.

comment:6 Changed 2 months ago by teor

Resolution: fixed
Status: merge_readyclosed

The travis build failed due to #29693, it is fixed in master.

I don't think we should backport this ticket:

  • new headers are almost always added to master
  • if they are backported, they will be merged to master first

Also, a backport would be a nightmare, due to the refactoring over 0.3.5 and 0.4.0.

Merged to master.

comment:7 Changed 9 days ago by gaba

Points: .10.1
Note: See TracTickets for help on using tickets.