Opened 3 months ago

Last modified 2 weeks ago

#29757 new defect

TBA: Delete Orbot Providers

Reported by: sysrqb Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, TorBrowserTeam201906
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Orbot (and OrbotService specifically) implement three Android app Providers:

  • HSContentProvider
  • FileProvider
  • CookieContentProvider

These are used by Orbot's onion service subsystem where the user can run a service from their device or store an auth cookie associated with an onion service.

We do not need these at this moment and we don't have plans for exposing a UI for these, and the existance of these prevents installing multiple versions of TBA (using different package names) because the Provider names collide. We can safely delete these from the service's manifest and TorService class.

Child Tickets

Change History (8)

comment:1 in reply to:  description ; Changed 3 months ago by sysrqb

Replying to sysrqb:

We do not need these at this moment and we don't have plans for exposing a UI for these, and the existance of these prevents installing multiple versions of TBA (using different package names) because the Provider names collide. We can safely delete these from the service's manifest and TorService class.

Note to self: the Tor port numbers conflict, as well. Future ticket.

comment:2 Changed 3 months ago by sysrqb

Keywords: tbb-8.5 added
Type: enhancement → defect

Moving this to tbb-8.5, the same reason for this ticket is actually preventing the app from working on a device running API level 16 (see ticket:28329#comment:84).

comment:3 Changed 3 months ago by gk

Keywords: tbb-8.5-must TorBrowserTeam201904 added; tbb-8.5 removed

comment:4 Changed 8 weeks ago by sysrqb

Status: new → needs_review

I have a branch for review in my tor-browser-build repo, bug29757_00. It simply deletes the class file (DataService.java) and deletes the code in TorServices where it is referenced. I think a better patch involves adding a preference (or something similar) where we can specify we don't want the additional content providers and tor-android-service simply skips the lines where DataService is configured, but I think we can work on that later.

comment:5 Changed 8 weeks ago by sysrqb

Keywords: tbb-8.5-must removed
Status: needs_review → new

Okay, new plan. There is an easier fix for getting this working on API 16. It seems if we drop the content-provider.patch for tor-android-service in tor-browser-build, then we avoid this problem. We can use #30371 for this change.

comment:6 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201905 added; TorBrowserTeam201904 removed

Moving tickets to May

comment:7 in reply to:  1 Changed 5 weeks ago by sysrqb

Replying to sysrqb:

Note to self: the Tor port numbers conflict, as well. Future ticket.

That's now #30551

comment:8 Changed 2 weeks ago by gk

Keywords: TorBrowserTeam201906 added; TorBrowserTeam201905 removed

Moving tickets to June

Note: See TracTickets for help on using tickets.