Opened 9 months ago
Last modified 4 months ago
#29757 new defect
TBA: Delete Orbot Providers
| Reported by: | sysrqb | Owned by: | tbb-team |
|---|---|---|---|
| Priority: | Medium | Milestone: | |
| Component: | Applications/Tor Browser | Version: | |
| Severity: | Normal | Keywords: | tbb-mobile, TorBrowserTeam201908 |
| Cc: | Actual Points: | ||
| Parent ID: | Points: | ||
| Reviewer: | Sponsor: |
Description
Orbot (and OrbotService specifically) implement three Android app Providers:
- HSContentProvider
- FileProvider
- CookieContentProvider
These are used by Orbot's onion service subsystem where the user can run a service from their device or store an auth cookie associated with an onion service.
We do not need these at this moment and we don't have plans for exposing a UI for these, and the existance of these prevents installing multiple versions of TBA (using different package names) because the Provider names collide. We can safely delete these from the service's manifest and TorService class.
Child Tickets
Change History (10)
comment:1 follow-up: 7 Changed 9 months ago by
comment:2 Changed 8 months ago by
| Keywords: | tbb-8.5 added |
|---|---|
| Type: | enhancement → defect |
Moving this to tbb-8.5, the same reason for this ticket is actually preventing the app from working on a device running API level 16 (see ticket:28329#comment:84).
comment:3 Changed 8 months ago by
| Keywords: | tbb-8.5-must TorBrowserTeam201904 added; tbb-8.5 removed |
|---|
comment:4 Changed 7 months ago by
| Status: | new → needs_review |
|---|
I have a branch for review in my tor-browser-build repo, bug29757_00. It simply deletes the class file (DataService.java) and deletes the code in TorServices where it is referenced. I think a better patch involves adding a preference (or something similar) where we can specify we don't want the additional content providers and tor-android-service simply skips the lines where DataService is configured, but I think we can work on that later.
comment:5 Changed 7 months ago by
| Keywords: | tbb-8.5-must removed |
|---|---|
| Status: | needs_review → new |
Okay, new plan. There is an easier fix for getting this working on API 16. It seems if we drop the content-provider.patch for tor-android-service in tor-browser-build, then we avoid this problem. We can use #30371 for this change.
comment:6 Changed 7 months ago by
| Keywords: | TorBrowserTeam201905 added; TorBrowserTeam201904 removed |
|---|
Moving tickets to May
comment:7 Changed 7 months ago by
comment:8 Changed 6 months ago by
| Keywords: | TorBrowserTeam201906 added; TorBrowserTeam201905 removed |
|---|
Moving tickets to June
comment:9 Changed 5 months ago by
| Keywords: | TorBrowserTeam201907 added; TorBrowserTeam201906 removed |
|---|
Moving tickets to July
comment:10 Changed 4 months ago by
| Keywords: | TorBrowserTeam201908 added; TorBrowserTeam201907 removed |
|---|
Moving more tickets to August
Replying to sysrqb:
Note to self: the Tor port numbers conflict, as well. Future ticket.