Opened 6 months ago

Last modified 6 months ago

#29766 new defect

Get us closer to use release build config

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

To make releases look more like Releases:

https://gitweb.torproject.org/tor-browser.git/tree/build/unix/mozconfig.linux32?h=tor-browser-60.5.1esr-8.5-1

#23656 Use .mozconfig files in tor-browser repo for rbm builds

+ac_add_options --enable-debug-symbols=""

+export BUILDING_RELEASE=1 (https://gitweb.torproject.org/tor-browser.git/tree/browser/config/mozconfigs/linux64/release?h=tor-browser-60.5.1esr-8.5-1)

-mk_add_options BUILD_OFFICIAL=1

-mk_add_options MOZILLA_OFFICIAL=1

-ac_add_options --enable-default-toolkit=cairo-windows

#29081 libwinpthread.dll has no ASLR

-O2 (-O3 for js) for mingw

-no-seh for win32

Child Tickets

Change History (5)

comment:1 Changed 6 months ago by gk

Keywords: tbb-rbm added
Priority: HighMedium
Severity: MajorNormal
Summary: Release preparationsGet us closer to use Mozilla's build config

comment:2 Changed 6 months ago by cypherpunks

to use Mozilla's build config

It is unacceptable.

#29758 replaces one obsolete config option with two.

What have you chosen for the current rel prep?

comment:3 Changed 6 months ago by cypherpunks

Keywords: tbb-8.5 added
Summary: Get us closer to use Mozilla's build configGet us closer to use release build config

This is needed to make TBB 8.5 the first release-grade quality series.

(+ac_add_options --enable-debug-symbols="" should fix HEASLR, btw)

comment:4 in reply to:  3 Changed 6 months ago by gk

Keywords: tbb-8.5 removed

Replying to cypherpunks:

This is needed to make TBB 8.5 the first release-grade quality series.

(+ac_add_options --enable-debug-symbols="" should fix HEASLR, btw)

How should that fix HEASLR?

comment:5 Changed 6 months ago by cypherpunks

So, you don't want to get it fixed in TBB 8.5?

Note: See TracTickets for help on using tickets.