Opened 2 months ago

Closed 6 weeks ago

#29768 closed defect (fixed)

Introduce new features to users in Tor Browser

Reported by: antonela Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201904R, tbb-8.5-must-alpha
Cc: ux-team, steph Actual Points:
Parent ID: #25658 Points:
Reviewer: Sponsor:

Description

We need to follow a pattern to introduce new features in Tor Browser.

The onboarding tour seems the best place to explain the feature in detail, but for recurrent users, we need to find a catchy way to encourage users to discover it.

Child Tickets

Attachments (12)

new-features-1.0.png (70.1 KB) - added by dunqan 2 months ago.
new-features-2.0.png (104.6 KB) - added by dunqan 2 months ago.
toolbar-update-8.5.png (140.7 KB) - added by mcs 8 weeks ago.
security-update-8.5.png (116.0 KB) - added by mcs 8 weeks ago.
new-features-3.0.png (80.2 KB) - added by dunqan 7 weeks ago.
new-features-4.0.png (85.5 KB) - added by dunqan 7 weeks ago.
new-features-3.1.png (71.2 KB) - added by dunqan 7 weeks ago.
new-features-4.1.png (78.6 KB) - added by dunqan 7 weeks ago.
security-onboarding 2019-04-04a.png (312.7 KB) - added by mcs 7 weeks ago.
1.1.png (446.4 KB) - added by antonela 6 weeks ago.
left_padding.png (6.3 KB) - added by gk 6 weeks ago.
no_left_padding.png (5.8 KB) - added by gk 6 weeks ago.

Download all attachments as: .zip

Change History (66)

comment:1 Changed 2 months ago by mcs

Also note (in case you are not aware): the onboarding mechanism allows us to specify a different list of topics for upgraded users vs. new users. This is accomplished by two prefs:

browser.onboarding.newtour
browser.onboarding.updatetour

(in Tor Browser, we currently have the same list in both prefs).

But we should also keep #28822 in mind since esr68 is not too far in our future.

comment:2 Changed 2 months ago by gk

Cc: tbb-8.5 added
Priority: MediumHigh

Bumping prio and getting on our 8.5 radar as we want to have this fixed for the stable when the new security settings feature ships.

comment:3 Changed 2 months ago by gk

Cc: tbb-8.5 removed
Keywords: tbb-8.5 added

Changed 2 months ago by dunqan

Attachment: new-features-1.0.png added

Changed 2 months ago by dunqan

Attachment: new-features-2.0.png added

comment:4 Changed 2 months ago by dunqan

Hey mcs/gk & antonela,

Some initial ideas for feedback below:

about:tor

  • Update the copy on the onboarding-speech-bubble
  • Reduce the border radius to ~12px
  • Add a notification dot (hex 00E2B1)

On that last point, would it be possible to animate the dot slightly? e.g. Could we make it pulse in CSS, like so here or here? Alternatively something like this would be subtler.

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29768/new-features-1.0.png

Onboarding

  • Automatically skip returning users down to the first "New" item
  • Replace tick icon with purple "NEW" pill for updated items (I've redrawn & increased the size of the tick icon slightly to match too)
  • Consider a highlight state for text to emphasise changes for returning users (this is really an optional extra, however I'm conscious that some updates in future may be quite subtle and may need the extra emphasis)

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29768/new-features-2.0.png

Full & downloadable .sketch doc here for reference antonela: https://sketch.cloud/s/d1Wv2

Thanks!

comment:5 Changed 8 weeks ago by gk

Keywords: TorBrowserTeam201903 added
Parent ID: #25658

Thanks, works for me.

comment:6 Changed 8 weeks ago by gk

Keywords: tbb-8.5-must added; tbb-8.5 removed

Marking blockers for Tor Browser 8.5.

comment:7 Changed 8 weeks ago by gk

Keywords: tbb-8.5-must-alpha added; tbb-8.5-must removed

Tickets that block the next 8.5 alpha.

Changed 8 weeks ago by mcs

Attachment: toolbar-update-8.5.png added

Changed 8 weeks ago by mcs

Attachment: security-update-8.5.png added

comment:8 in reply to:  4 Changed 8 weeks ago by mcs

Status: newneeds_information

Replying to dunqan:

Hey mcs/gk & antonela,

Some initial ideas for feedback below:

about:tor

  • Update the copy on the onboarding-speech-bubble
  • Reduce the border radius to ~12px
  • Add a notification dot (hex 00E2B1)

Thanks for working on this! The above changes sound good.

On that last point, would it be possible to animate the dot slightly? e.g. Could we make it pulse in CSS, like so here or here? Alternatively something like this would be subtler.

We will see what we can do.

...

Onboarding

  • Automatically skip returning users down to the first "New" item
  • Replace tick icon with purple "NEW" pill for updated items (I've redrawn & increased the size of the tick icon slightly to match too)
  • Consider a highlight state for text to emphasise changes for returning users (this is really an optional extra, however I'm conscious that some updates in future may be quite subtle and may need the extra emphasis)

After looking at Mozilla's implementation, Kathy and I would like to make a propose a different approach. Mozilla's model is that returning users (e.g., those who have updated their browser) are shown a completely different set of onboarding pages. That way there is no confusion about which items are new and which are not. Here are some mockups to show what it might look like if we had two items in our "updated" tour:

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29768/toolbar-update-8.5.png

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29768/security-update-8.5.png

Thoughts? We would need a new image for the "Toolbar" page (or we could remove the image). And all of the copy needs work.

comment:9 Changed 8 weeks ago by gk

Works for me. In particular, as Mozilla probably has spent way more thought and testing on finding the right approach to onboarding than we.

comment:10 Changed 8 weeks ago by dunqan

Thanks both! That certainly seems like a far cleaner solution.

Would the consequences of this approach be that existing users could no longer return to the base onboarding once an update's been released?

I don't think we've got any data on how often users return to this feature after initial onboarding – do we?

comment:11 in reply to:  10 Changed 8 weeks ago by mcs

Replying to dunqan:

Would the consequences of this approach be that existing users could no longer return to the base onboarding once an update's been released?

Yes. The update "track" (aka tour type) is selected if the browser has been opened at least once with an older version of the tour set (this is handled via hidden prefs named browser.onboarding.tourset-version and browser.onboarding.seen-tourset-version). So far we have only used one one tour set version, which is 2. When we release Tor Browser 8.5 we would bump that to 3, which means users who upgrade to 8.5 will be placed on the update track. New users will remain on the "new" track until we release a Tor Browser that has a tour set version higher than 3. The logic that implements tour selection is here:
https://gitweb.torproject.org/tor-browser.git/tree/browser/extensions/onboarding/OnboardingTourType.jsm#n22

I don't think we've got any data on how often users return to this feature after initial onboarding – do we?

No, not unless some data (or feeling) was captured during the UX testing sessions.

comment:12 Changed 8 weeks ago by dunqan

Great, thanks mcs!

No, not unless some data (or feeling) was captured during the UX testing sessions.

Anecdotally I've came across a couple of novice users who returned to the onboarding after the initial run-through to reference certain features, but there hasn't been any testing on this subject afaik.

Nonetheless replacing the illustrations with screenshots on the "updated" onboarding screen (as per your proposal) may provide a little more flexibility when introducing new features in future?

If you can fire me a screenshot or visual of the toolbar change I can mock this up for you :)

(Sorry, I'm not familiar with that ticket)

Last edited 8 weeks ago by dunqan (previous) (diff)

comment:13 in reply to:  12 Changed 8 weeks ago by mcs

Status: needs_informationnew

Replying to dunqan:

Nonetheless replacing the illustrations with screenshots on the "updated" onboarding screen (as per your proposal) may provide a little more flexibility when introducing new features in future?

If you can fire me a screenshot or visual of the toolbar change I can mock this up for you :)

The toolbar changes were done in #25658. In am not sure what you have in mind for the toolbar screenshot, so probably you should compare the toolbars in Tor Browser 8.0.8 and 8.5a10 and then grab screenshots from 8.5a10. A quick summary of the changes:

  • Added Security Level (shield) icon.
  • Moved Torbutton (onion) after the URL bar.
  • Removed NoScript and HTTPS-Everywhere icons.

comment:14 Changed 7 weeks ago by dunqan

Gotcha. Will whip something together asap.

comment:15 in reply to:  12 Changed 7 weeks ago by antonela

Replying to dunqan:

Hey, I think that can be useful if we remove the illo and we include a UI mockup of the new toolbar. Perhaps, can we have a gif?

For 1. Toolbar, we can have the old one and the new one. A little loop showing how the new icons appear could be illustrative for users that don't even know what "toolbar" stands for. Showing that we are hiding HTTPS-E and NoScript icons may be problematic.

For 2. Security Settings, we could have a little loop showing how the doorhanger appears?

Is possible that having gifs is a problem. So, for both options, the static .png (300x300) is necessary.

Thanks dunqan!

Great, thanks mcs!

No, not unless some data (or feeling) was captured during the UX testing sessions.

Anecdotally I've came across a couple of novice users who returned to the onboarding after the initial run-through to reference certain features, but there hasn't been any testing on this subject afaik.

Nonetheless replacing the illustrations with screenshots on the "updated" onboarding screen (as per your proposal) may provide a little more flexibility when introducing new features in future?

If you can fire me a screenshot or visual of the toolbar change I can mock this up for you :)

(Sorry, I'm not familiar with that ticket)

Changed 7 weeks ago by dunqan

Attachment: new-features-3.0.png added

Changed 7 weeks ago by dunqan

Attachment: new-features-4.0.png added

comment:16 Changed 7 weeks ago by dunqan

Replying to antonela:

Hey, I think that can be useful if we remove the illo and we include a UI mockup of the new toolbar. Perhaps, can we have a gif?

Yep, exactly what I was thinking! I mocked up these two static images last night, but I didn't realise the image size is different on TB vs Sketch so will need to fix that up first.

Any preference/recommendations for animation tools antonela?

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29768/new-features-3.0.png

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29768/new-features-4.0.png

comment:17 Changed 7 weeks ago by antonela

Dunqan, I think both look great. We don't need an animation for this iteration. Let's wait for devs feedback and then share the assets with them for implementation. Thanks!

comment:18 in reply to:  17 Changed 7 weeks ago by mcs

Replying to antonela:

Dunqan, I think both look great. We don't need an animation for this iteration. Let's wait for devs feedback and then share the assets with them for implementation. Thanks!

Kathy and I don't have any experience with using animated gifs inside Firefox chrome code, but it should be possible. The only thing I would worry about is controlling when the animation begins; for example, all of the onboarding tour panels are loaded as soon as onboarding is opened (even the hidden ones). Ideally, an animated gif would play from the beginning each time someone switched to the panel it is on, so we would need to figure out how to control "playback."

That's a long-winded way of saying that Kathy and I are okay with skipping animation for this round :)

Changed 7 weeks ago by dunqan

Attachment: new-features-3.1.png added

Changed 7 weeks ago by dunqan

Attachment: new-features-4.1.png added

comment:19 Changed 7 weeks ago by dunqan

Haha, no worries!

I've updated the Sketch file to better reflect the live dimensions of the onboarding card on TB: https://sketch.cloud/s/d1Wv2

The only other addition I've made to the "updated" onboarding cards are the meta-labels above the card titles (to clean up long titles a little). It's strictly optional however!

300x300 PNGs @1x, 2x and 3x can be found here: https://www.dropbox.com/sh/nmyrpysuxtrr7s6/AABXxN0QA8_r47Osvie8-fF2a?dl=0

(Have cronched the filesizes down a bit too.)

All good folks?

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29768/new-features-3.1.png

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29768/new-features-4.1.png

comment:20 Changed 7 weeks ago by antonela

thanks dunqan!

gk, do we have your approval?
mcs, are those assets good for the implementation?

Thanks all!

comment:21 Changed 7 weeks ago by gk

If mcs/brade are fine with it then this looks good to me, thanks!

comment:22 in reply to:  21 ; Changed 7 weeks ago by mcs

Replying to gk:

If mcs/brade are fine with it then this looks good to me, thanks!

Yes, we will work on implementing it.

Dunqan — can you provide colors and corner radius for the Updated and New meta-labels? If you provide CSS we would use it ;)

Antonela — what do we need to do to finalize the English text? We should do that soon so there is time for translation.

comment:23 in reply to:  22 Changed 7 weeks ago by dunqan

Replying to mcs:

Dunqan — can you provide colors and corner radius for the Updated and New meta-labels? If you provide CSS we would use it ;)

Sure thing! CSS attributes as follows:

background: #F1F1F3;
border-radius: 4px;
Min-height: 25px;
font-size: 10px;
font-weight: 600;
text-transform: uppercase;

comment:24 in reply to:  22 Changed 7 weeks ago by antonela

Replying to mcs:

Antonela — what do we need to do to finalize the English text? We should do that soon so there is time for translation.

Started a thread with stephw to have her review. Thanks!

comment:25 Changed 7 weeks ago by antonela

Cc: stephw added

comment:26 Changed 7 weeks ago by antonela

Cc: steph added; stephw removed

comment:27 Changed 7 weeks ago by antonela

As we discussed via email, we have three group of users:

Updated Users (via automatic updates)

This group of users will have an onboarding tour, automatically prompted when they launch the updated browser with 2(two) sections, following comment:19 designs. Copy will say:

Toolbar layout
We improved the browser toolbar layout. We moved the Torbutton icon after the URL bar, and we added a security level icon next to it. The NoScript and HTTPS-Everywhere icons are no longer included in the toolbar by default, but you can customize your toolbar to add them back.
Security level experience
We improved how you see and set your security level. We replaced the security slider with a toolbar icon that makes your current level visible at all times. Click it to view details about your current level or to change your security settings.

New Users (could be recurrent, but with a fresh installation)

This group of users will have the regular onboarding tour, automatically prompted when they start the browser with 7(seven) sections. The Security Section will have the new label.

First Time Users

Same onboarding, like a New User.

mcs/brade/pospeselr are we good with this? am i missing anything?

comment:28 Changed 7 weeks ago by gk

I think for the updated users the HTTPS Everywhere and NoScript icons are still there as pospeselr mentioned (we should rule out last doubts here, though). Thus, as mcs said the sentence pointing to those buttons is not needed anymore in this case.

comment:29 Changed 7 weeks ago by antonela

Okey, is that the expected behavior? Are we ok removing that part? Can we have a patch to frieze those strings so we can move to translate?

comment:30 Changed 7 weeks ago by pospeselr

Can confirm, Updated Users will still see NoScript and HTTPS-Everywhere (along with any other user initiated UI customizations such as theme and other extension icons) exactly where they left them prior to update, but Torbutton will move and Security Level button placed alongside it.

The Updated Users copy can remove the entire last sentence about NoScript and HTTPS-Everywhere.

comment:31 Changed 7 weeks ago by mcs

Keywords: TorBrowserTeam201903R added; TorBrowserTeam201903 removed
Status: newneeds_review

Okay, here is our torbutton patch (add new strings):
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug29768-01&id=9d7c1081105eb3858f6654daa31202d4bac1d84f

And here is our tor-browser patch (make all the new stuff work):
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug29768-01&id=e4a163b58530f37b7f292fe49ad7b882b2f046d0

Adding the attention-grabbing dot took some work but it seems worthwhile. We ended up using a variation of the third animation that Dunqan suggested in comment:4 (a simple pulsating "dot" that stops animating after 14 seconds). Kathy and I think it looks good without being too annoying. Once we have a new nightly build everyone should take a look at it. You can force the 8.5 update tour to be displayed by opening the browser, using about:config to set browser.onboarding.tourset-version to 2 (instead of the new default value of 3), and then restarting the browser.

comment:32 Changed 7 weeks ago by pospeselr

The patches looks good to me.

comment:33 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201904 added

Moving tickets to April.

comment:34 in reply to:  31 Changed 7 weeks ago by gk

Replying to mcs:

Okay, here is our torbutton patch (add new strings):
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug29768-01&id=9d7c1081105eb3858f6654daa31202d4bac1d84f

And here is our tor-browser patch (make all the new stuff work):
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug29768-01&id=e4a163b58530f37b7f292fe49ad7b882b2f046d0

Adding the attention-grabbing dot took some work but it seems worthwhile. We ended up using a variation of the third animation that Dunqan suggested in comment:4 (a simple pulsating "dot" that stops animating after 14 seconds). Kathy and I think it looks good without being too annoying. Once we have a new nightly build everyone should take a look at it. You can force the 8.5 update tour to be displayed by opening the browser, using about:config to set browser.onboarding.tourset-version to 2 (instead of the new default value of 3), and then restarting the browser.

Looks good to me. I merged the Torbutton patch to master (commit 9d7c1081105eb3858f6654daa31202d4bac1d84f) and the browser patch to tor-browser (commit e4a163b58530f37b7f292fe49ad7b882b2f046d0).

For anyone testing that in, say, nightly builds the pref to actually set tp 2 is browser.onboarding.seen-tourset-version.

comment:35 Changed 7 weeks ago by dunqan

Is this the place to get Nightly builds from? Couldn't see anything on the regular dist/download URLs.

http://f4amtbsowhix7rrf.onion/tor-browser-builds/

Also installing Nightly alongside Stable/Alpha seems to break the browser for me on MacOS – any tips there? e.g. Should I be installing & running Tor Nightly in a VM instead?

Apologies for the noob questions ;)

comment:36 in reply to:  35 ; Changed 7 weeks ago by mcs

Replying to dunqan:

Is this the place to get Nightly builds from? Couldn't see anything on the regular dist/download URLs.

http://f4amtbsowhix7rrf.onion/tor-browser-builds/

Yes, although the changes for this ticket probably aren't in the latest nightlies (wait for the next builds).

Also installing Nightly alongside Stable/Alpha seems to break the browser for me on MacOS – any tips there? e.g. Should I be installing & running Tor Nightly in a VM instead?

I am not sure how your browser broke, but you cannot run two copies of Tor Browser at the same time unless you change the ports used by the tor daemon. Also, it is best to avoid sharing browser profiles and other data between e.g., stable and nightly. On macOS, creating a folder for each .app is a good approach; that way, each copy of the browser will have its own TorBrowser-Data directory.

Changed 7 weeks ago by mcs

comment:37 Changed 7 weeks ago by mcs

To help recurring users who do a fresh install, we could improve the Security onboarding page to include [New] (as Antonela suggested in comment:27; sorry I missed that) and we could also add a text note about the NoScript and HTTPS-E changes (a suggestion from gk). Here is a prototype:

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29768/security-onboarding%202019-04-04a.png

Kathy and I think this looks pretty good, although adding [New] at the top and the note at the bottom nearly fills the available space. That might be a problem in some languages.

comment:38 in reply to:  36 Changed 7 weeks ago by dunqan

Replying to mcs:

I am not sure how your browser broke, but you cannot run two copies of Tor Browser at the same time unless you change the ports used by the tor daemon. Also, it is best to avoid sharing browser profiles and other data between e.g., stable and nightly. On macOS, creating a folder for each .app is a good approach; that way, each copy of the browser will have its own TorBrowser-Data directory.

Gotcha, thanks mcs!

Last edited 7 weeks ago by dunqan (previous) (diff)

comment:39 Changed 7 weeks ago by mcs

Keywords: TorBrowserTeam201903R removed
Status: needs_reviewneeds_information

Switching status to "needs information" to solicit reactions to my comment:37 (proposed changes to the regular/new user onboarding).

comment:40 in reply to:  39 Changed 7 weeks ago by gk

Replying to mcs:

Switching status to "needs information" to solicit reactions to my comment:37 (proposed changes to the regular/new user onboarding).

I am fine leaving that Note out if we think it's too risky space-wise.

comment:41 Changed 7 weeks ago by gk

I wonder what we mean by adding "New" to the pane if we keep the old text because that pane and the functionality behind that feature aren't actually new. So, hrm...

Changed 6 weeks ago by antonela

Attachment: 1.1.png added

comment:42 Changed 6 weeks ago by antonela

I think we should keep the New label, even if is a new user. That will show that we are constantly improving.

Regarding comment:37:

  • the Note part needs to have a smaller text size, in order to improve the hierarchy of the elements there. font-size:13px seems appropriate.
  • I see the space constraint here. Do you think that moving the New label to the left menu item will help? See the attachment.

I'm wondering how we can know if this install is from a First Time User or a Recurrent user with a fresh install itself. Having that note for First Time Users is very confusing.

Last edited 6 weeks ago by mcs (previous) (diff)

comment:43 in reply to:  42 ; Changed 6 weeks ago by gk

Replying to antonela:

I think we should keep the New label, even if is a new user. That will show that we are constantly improving.

Regarding comment:37:

  • the Note part needs to have a smaller text size, in order to improve the hierarchy of the elements there. font-size:13px seems appropriate.
  • I see the space constraint here. Do you think that moving the New label to the left menu item will help? See the attachment.

I'm wondering how we can know if this install is from a First Time User or a Recurrent user with a fresh install itself. Having that note for First Time Users is very confusing.

Discriminating between both is not really possible. It might be possible in some circumstances but those would be rare. Thus, I think we should not build our onboarding with that distinction in mind.

comment:44 in reply to:  43 ; Changed 6 weeks ago by antonela

Replying to gk:

Discriminating between both is not really possible. It might be possible in some circumstances but those would be rare. Thus, I think we should not build our onboarding with that distinction in mind.

That is what I thought, exactly. So, Is that note needed for fresh installs?

comment:45 in reply to:  44 ; Changed 6 weeks ago by gk

Replying to antonela:

Replying to gk:

Discriminating between both is not really possible. It might be possible in some circumstances but those would be rare. Thus, I think we should not build our onboarding with that distinction in mind.

That is what I thought, exactly. So, Is that note needed for fresh installs?

If I understood the copy discussion correctly then there was the idea to get those folks less confused that came back to Tor Browser with a clean install wondering where those icons were gone. They might resort to the onboarding and would find the NEW item and would be happy. However, that might cause too much confusion for first-time users to be worth it. Hard to say. I am fine dropping that plan and just provide something for users that updated while any user of a freshly installed Tor Browsers just gets an updated onboarding (if that's necessary) without a "NEW" hint whatsoever.

Last edited 6 weeks ago by gk (previous) (diff)

comment:46 in reply to:  45 ; Changed 6 weeks ago by gk

Replying to gk:

Replying to antonela:

Replying to gk:

Discriminating between both is not really possible. It might be possible in some circumstances but those would be rare. Thus, I think we should not build our onboarding with that distinction in mind.

That is what I thought, exactly. So, Is that note needed for fresh installs?

If I understood the copy discussion correctly then there was the idea to get those folks less confused that came back to Tor Browser with a clean install wondering where those icons were gone. They might resort to the onboarding and would find the NEW item and would be happy. However, that might cause too much confusion for first-time users to be worth it. Hard to say. I am fine dropping that plan and just provide something for users that updated while any user of a freshly installed Tor Browsers just gets an updated onboarding (if that's necessary) without a "NEW" hint whatsoever.

If that sounds reasonable should we just leave the onboarding as it is for now OR should we add the Note? (Or should we do something differently?)

comment:47 in reply to:  46 ; Changed 6 weeks ago by mcs

Replying to gk:

If that sounds reasonable should we just leave the onboarding as it is for now OR should we add the Note? (Or should we do something differently?)

Maybe we should include a slightly re-worded note that will be less confusing to completely new users, e.g.,

Note: By default, NoScript and HTTPS-Everywhere are not included on the toolbar, but you can customize your toolbar to add them.

But maybe such a note encourages new users to go looking for NoScript and HTTPS-E, which we may not want.

comment:48 in reply to:  47 Changed 6 weeks ago by antonela

Replying to mcs:

Note: By default, NoScript and HTTPS-Everywhere are not included on the toolbar, but you can customize your toolbar to add them.

Okey, let's do it. This copy seems reasonable for me. Thanks!

comment:49 Changed 6 weeks ago by gk

Status: needs_informationnew

comment:50 Changed 6 weeks ago by mcs

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201904 TorBrowserTeam201904 removed
Status: newneeds_review

Here is a Torbutton patch to add one additional string (the note from comment:47):
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug29768-02&id=de2b60ea51bf0c5e3be720c84ef1c121a00b4f1d

And here is a fixup patch for tor-browser that adds the note to the Security onboarding page, moves the [New] and [Updated] highlight "tags" to the navigation column, and fixes a problem where the security level image was reversed when using an RTL language:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug29768-01&id=7706b044c9a013ae205168038ae8a734b2249741

The "updated for 8.5" security level image is problematic because it contains a screenshot that shows English text. I don't think we have time to revisit that right now, but I filed #30104 to track that issue.

comment:51 Changed 6 weeks ago by gk

The new patches look good to me. I merged them to master (commit de2b60ea51bf0c5e3be720c84ef1c121a00b4f1d) (Torbutton) and the browser (tor-browser-60.6.1esr-8.5-1) (commit 7706b044c9a013ae205168038ae8a734b2249741).

One thing I noticed, which I missed in my earlier reviews: the Tor logo left to the onboarding bubble is now closely aligned to the left side. This got prevented previously by having offset-inline-start: 12px for the onboarding-overlay-button. Could we fix that in a follow-up fixup? I am attaching screen shots shortly.

Changed 6 weeks ago by gk

Attachment: left_padding.png added

Changed 6 weeks ago by gk

Attachment: no_left_padding.png added

comment:52 Changed 6 weeks ago by gk

Status: needs_reviewneeds_information

This is how it looks like in the alpha:

and this is how it looks after the changes in this bug (I have not checked but that's very likely) made it into our nightly builds:

comment:53 in reply to:  51 ; Changed 6 weeks ago by mcs

Status: needs_informationneeds_review

Replying to gk:

One thing I noticed, which I missed in my earlier reviews: the Tor logo left to the onboarding bubble is now closely aligned to the left side. This got prevented previously by having offset-inline-start: 12px for the onboarding-overlay-button. Could we fix that in a follow-up fixup? I am attaching screen shots shortly.

Good catch. Here is a fixup:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug29768-01&id=f29aef752c7bb1a6215bc537fff1d742ea0961fe

comment:54 in reply to:  53 Changed 6 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to mcs:

Replying to gk:

One thing I noticed, which I missed in my earlier reviews: the Tor logo left to the onboarding bubble is now closely aligned to the left side. This got prevented previously by having offset-inline-start: 12px for the onboarding-overlay-button. Could we fix that in a follow-up fixup? I am attaching screen shots shortly.

Good catch. Here is a fixup:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug29768-01&id=f29aef752c7bb1a6215bc537fff1d742ea0961fe

Looks good. Merged to tor-browser-60.6.1esr-8.5 (commit f29aef752c7bb1a6215bc537fff1d742ea0961fe). I think we are done here. \o/

Note: See TracTickets for help on using tickets.