Opened 7 months ago

Closed 7 months ago

#29813 closed defect (duplicate)

Add unmeasured and vote Line KeyValues in the bandwidth-file-spec

Reported by: juga Owned by: juga
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, bandwidth-file-spec, tor-bwauth
Cc: Actual Points:
Parent ID: #28563 Points: 1
Reviewer: nickm, teor Sponsor:

Child Tickets

Change History (15)

comment:1 Changed 7 months ago by juga

Status: assignedneeds_review

It might need some rephrasing: https://github.com/torproject/torspec/pull/64.

See #28563 for the sbws implementation and #29806 for the Tor implementation

comment:2 Changed 7 months ago by juga

Parent ID: #28547#28563

Change parent, since this might need to be reviewed with #28563

comment:3 Changed 7 months ago by juga

I realized about #29814 while working on this.

comment:4 Changed 7 months ago by nickm

Reviewer: nickm

comment:5 Changed 7 months ago by nickm

Status: needs_reviewneeds_revision

This looks okay to me, but we will need to change the listed versions when we merge this.

comment:6 Changed 7 months ago by teor

I also did a review on this spec change.
I think we need to explain why we are making the spec change, as well as what tor should do.

comment:7 Changed 7 months ago by teor

Reviewer: nickmnickm, teor

comment:8 Changed 7 months ago by juga

I pushed all teor's suggestions

comment:9 Changed 7 months ago by juga

i'll leave it in revision until i do next relase

comment:10 Changed 7 months ago by teor

There is one typo in the spec, I added a comment on the pull request.

I think we can merge this change when #29806 merges.

Why do you want to wait until the next sbws release?
If we keep this pull request open, and you make another pull request on torspec master, they might have conflicts.

comment:11 in reply to:  10 Changed 7 months ago by juga

Replying to teor:

There is one typo in the spec, I added a comment on the pull request.

made other fixup

I think we can merge this change when #29806 merges.

ok

Why do you want to wait until the next sbws release?

i thought nickm was refering to sbws with:

but we will need to change the listed versions when we merge this.

because of https://github.com/torproject/torspec/pull/64/commits/171daa9b2d819c8aea963a557f82891fdeb2670f#diff-824f4c7404328d8aa1101d74ba36884dL699
But he might have mean Tor version.
I changed 1.1.X by 1.1.0, didn't realize that doesn't matter there'll be a 1.1.1 later, this change will be included in 1.1.0.
So yes, we don't need to wait for sbws relase.

If we keep this pull request open, and you make another pull request on torspec master, they might have conflicts.

agree

comment:12 Changed 7 months ago by juga

Resolution: implemented
Status: needs_revisionclosed

ok, let's merge it

comment:13 Changed 7 months ago by juga

Resolution: implemented
Status: closedreopened

ops

comment:14 Changed 7 months ago by juga

Status: reopenedmerge_ready

comment:15 Changed 7 months ago by teor

Resolution: duplicate
Status: merge_readyclosed

Rebased on to #29754, because there were conflicts. Let's deal with it in #29754.

Note: See TracTickets for help on using tickets.