Opened 5 months ago

Last modified 10 days ago

#29818 new defect

adapt #13379 patch for 68esr

Reported by: mcs Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-update, ff68-esr, tbb-9.0-must-alpha, TorBrowserTeam201908
Cc: brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor44-can

Description (last modified by gk)

In https://bugzilla.mozilla.org/show_bug.cgi?id=1434033, Mozilla removed the use of LD_LIBRARY_PATH (which is used in non-macOS and non-Windows Firefox to ensure that the updater can locate NSS related shared libraries). Instead, the Firefox build now adds -rpath=$ORIGIN in LDFLAGS.

For Tor Browser, we need a similar solution for Windows and macOS because we define MAR_NSS on all platforms (we define MAR_NSS so that we use NSS for MAR-related crypto on all platforms rather than relying on OS-provided libraries). Therefore, we will need to adapt our #13379 patch to account for Mozilla's change.

Current (Tor Browser 8.5a9) patch:
https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-browser-60.6.0esr-8.5-1&id=c17b8a3fbcd19230706f295a00ce955c1bcf90b9

Related Firefox bugs:
https://bugzilla.mozilla.org/show_bug.cgi?id=1434033
https://bugzilla.mozilla.org/show_bug.cgi?id=1434666

Child Tickets

Change History (4)

comment:1 Changed 5 months ago by gk

Description: modified (diff)
Keywords: ff68-esr added; f68-esr removed

comment:2 Changed 13 days ago by pili

Sponsor: Sponsor44-can

Adding Sponsor 44 to ESR68 tickets

comment:3 Changed 13 days ago by mcs

Keywords: tbb-9.0-must-alpha added

comment:4 Changed 10 days ago by gk

Keywords: TorBrowserTeam201908 added
Priority: MediumHigh
Note: See TracTickets for help on using tickets.