Opened 17 months ago

Closed 8 months ago

#29826 closed defect (fixed)

Rename router_status_t to avoid confusion with routerstatus_t

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt, fast-fix
Cc: Actual Points: 0
Parent ID: Points: 0.2
Reviewer: asn Sponsor:

Description (last modified by teor)

Tor has routerstatus_t in many files, and a router_status_t in process_descs.c.

That's terribly confusing, we should rename router_status_t.

Child Tickets

Change History (10)

comment:1 Changed 17 months ago by teor

This change would conflict with #22029, so we should do it after #22029 merges.

comment:2 Changed 17 months ago by teor

Summary: Rename router_status_t, to avoid confusion with routerstatus_tRename router_status_t to avoid confusion with routerstatus_t

comment:3 Changed 17 months ago by teor

Description: modified (diff)

More typos

comment:4 Changed 16 months ago by neel

Owner: set to neel
Status: newassigned

comment:5 Changed 9 months ago by neel

Owner: neel deleted

comment:6 Changed 9 months ago by neel

Status: assignednew

comment:7 Changed 9 months ago by nickm

Actual Points: 0
Keywords: easy intro removed
Milestone: Tor: unspecifiedTor: 0.4.3.x-final
Owner: set to nickm
Status: newaccepted

comment:8 Changed 9 months ago by nickm

Status: acceptedneeds_review

Branch is ticket29826 with PR at https://github.com/torproject/tor/pull/1559

The replace_c_identifiers.py script made this fast and easy.

comment:9 Changed 9 months ago by dgoulet

Reviewer: asn

comment:10 Changed 8 months ago by asn

Resolution: fixed
Status: needs_reviewclosed

LGTM! Merged!

Note: See TracTickets for help on using tickets.