Backport fix for bug 1527534 for Tor Browser for Android

Bug 1527534 got fixed in Firefox 66 but not backported to ESR 60 because Mozilla is not shipping any mobile browser based on ESR. But we do and should backport the patch.

added GeorgKoppen201904 TorBrowserTeam201904R component::applications/tor browser owner::tbb-team priority::high resolution::fixed severity::normal status::closed tbb-8.5-must type::task labels

Trac:
Keywords: N/A deleted, GeorgKoppen201903 added

bug_29843 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_29843&id=b619af79d04bde9313d8a4a2696c4a5a06c60175) in my tor-browser-build repo has the backport. I went that route because I don't want to have the desktop platforms exposed to the backport as it did not get any ESR testing on Mozilla's infra (Mozilla did not backport the patch themselves as they are not shipping mobile based on ESR).

It is compiling and the build is running on my phone. However, I did not get WebGL to run to further test the patch. Not sure what the problem is...

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201903 deleted, TorBrowserTeam201903R added

Seems reasonable. It's a little ugly, but I agree this is a safer method of applying the patch than applying it on all platforms. I haven't tested the patch yet, but it looks good. I'll confirm tomorrow.

Marking blockers for Tor Browser 8.5.

Trac:
Keywords: tbb-8.5 deleted, tbb-8.5-must added

Moving review tickets to April.

Trac:
Keywords: TorBrowserTeam201903R deleted, TorBrowserTeam201904R added

Moving my tickets for April

Trac:
Keywords: GeorgKoppen201903 deleted, GeorgKoppen201904 added

I can't easily test this on an older Android version due to #29906 (moved), but it works without any apparent issues on newer versions - therefore lgtm.

Trac:
Status: needs_review to merge_ready

Thanks, it should be in the next nightly so you could easily double-check that way :) Anyway, merged to tor-browser-build's master (commit 3ba210064197298ad1c54ca74f086a67653109a2).

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

mentioned in issue #30665 (moved)

moved to tpo/applications/tor-browser#29843 (closed)