#29844 closed defect (fixed)

Make sure that all torbutton branches give AB-CD instead of AB_CD

Reported by: emmapeel Owned by: gk
Priority: Medium Milestone:
Component: Community/Translations Version:
Severity: Normal Keywords:
Cc: tbb-team, gk, ggus Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by gk)

we need to consistently change to bn-BD along the repo and any other "AB_CD" style locale we need

Child Tickets

TicketStatusOwnerSummaryComponent
#28473closedemmapeelmove tbb resources in bn to bn-BDCommunity/Translations
#29940closedemmapeelmerges in transifexCommunity/Translations

Change History (6)

comment:1 Changed 19 months ago by gk

Description: modified (diff)
Summary: Make sure that all torbutton branches give bn-BDMake sure that all torbutton branches give AB-CD instead of AB_CD

OKay, there are two things here we might want to do:

1) Give our branches the correct syntax. If you look at https://hg.mozilla.org/l10n-central there is no single locale with a _. If we need composed parts we should use a - instead.

2) We could clean up all the locales we offer in Torbutton but which have no matching counerpart on Mozilla's side.

For 1) this affects bn_BD, en_GB, es_AR, es_CL, es_ES, es_MX, gu_IN, pt_BR, pt_PT, zh_CN, and zh_TW. The other ones are cases for 2).

For 2) I am unsure whether we really want to do that now as we are moving away for Torbutton anyway soon and need to come up with a new translation solution in that wake.

However, we could do 1) and 2) for Tor Launcher (too) as that one is staying longer with us...

Last edited 19 months ago by gk (previous) (diff)

comment:2 Changed 19 months ago by gk

There are still branches with _ instead of - (e.g. abouttor-homepage). Here are all the branches we care about:

FILEMAP=( "aboutDialog.dtd:torbutton-aboutdialogdtd"
          "aboutTor.dtd:abouttor-homepage"
          "aboutTBUpdate.dtd:torbutton-abouttbupdatedtd"
          "brand.dtd:torbutton-branddtd"
          "brand.properties:torbutton-brandproperties"
          "browserOnboarding.properties:torbutton-browseronboardingproperties"
          "torbutton.dtd:torbutton-torbuttondtd"
          "torbutton.properties:torbutton-torbuttonproperties"
          "securityLevel.properties:torbutton-securitylevelproperties"
         )

(FILEMAP contains local_file:translation_branch mappings)

comment:3 Changed 19 months ago by emmapeel

ok fixed abouttor-homepage, I missed cause of lack of torbutton- suffix...

i think they are all done now

comment:4 Changed 19 months ago by gk

Thanks. I think we are good here and this ticket can get closed from my PoV once #29940 is done. I created #29943 for the Torbutton changes.

comment:5 Changed 18 months ago by emmapeel

Owner: changed from emmapeel to gk

I think this ticket can be closed now.

I reassign to you in case you want to have a look before.

comment:6 Changed 18 months ago by gk

Resolution: fixed
Status: assignedclosed

Thanks, closing.

Note: See TracTickets for help on using tickets.