Opened 3 months ago

Closed 3 months ago

#29874 closed defect (fixed)

torrc no longer accepts space in executable paths

Reported by: cypherpunks Owned by: ahf
Priority: High Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor: 0.4.0.1-alpha
Severity: Normal Keywords: 040-must, regression, Windows, 040-backport, teor-merge, asn-merge, nickm-merge
Cc: Actual Points: 0.1
Parent ID: Points: 1
Reviewer: cohosh Sponsor: Sponsor19-must

Description

I'm not sure exactly when this change happened but 0.3.5.8 still works with a space in the executable path while 0.4.0.2 fails to launch the executable with the same torrc file.

The following is an example torrc line that no longer works:

ClientTransportPlugin obfs2,obfs3,obfs4,scramblesuit exec C:\Program Files\obfs4proxy.exe

Is this change documented somewhere? I'd like to keep the executable path unchanged if there is a simple workaround

Child Tickets

Change History (8)

comment:1 Changed 3 months ago by teor

Keywords: 040-must regression Windows? added
Milestone: Tor: 0.4.0.x-final
Owner: set to ahf
Points: 1
Status: newassigned

ahf has a local Windows box and might be able to diagnose this faster than the rest of us.

ahf, let me know if you want me to give your other 0.4.0 bugs to other people?
Have you started working on any of them yet?

comment:2 Changed 3 months ago by ahf

This should be fine for me to take, and yes, both of are in progress.

comment:3 Changed 3 months ago by ahf

Actual Points: 0.1

Let's see if both Travis and Appveyor likes https://github.com/torproject/tor/pull/835

comment:4 Changed 3 months ago by teor

Keywords: Windows added; Windows? removed
Sponsor: Sponsor19-must
Status: assignedneeds_review
Version: Tor: 0.4.0.3-alphaTor: 0.4.0.1-alpha

The CI passed.

Thanks for the fast fix!

comment:5 Changed 3 months ago by nickm

Priority: MediumHigh

comment:6 Changed 3 months ago by asn

Reviewer: cohosh

comment:7 Changed 3 months ago by cohosh

Status: needs_reviewmerge_ready

Looks good!

comment:8 Changed 3 months ago by teor

Keywords: 040-backport teor-merge asn-merge nickm-merge added
Resolution: fixed
Status: merge_readyclosed

Merged to maint-0.4.0 and merged forward.

Note: See TracTickets for help on using tickets.