get_proxy_type() may be wrong when unused PT configured
Related to #28925 (moved), it looks like get_proxy_type()
in connection.c only checks whether any client transport plugins are configured to determine whether a pluggable transport is in use. If ClientTransportPlugin
is set, but no bridges are configured to use it, and a SOCKS proxy is also configured, maybe some code in connection.c could inappropriately attempt to do PT stuff when it should only be doing vanilla SOCKS proxy stuff?
It might turn out to be ok, but it's not immediately obvious.