Opened 3 months ago

Last modified 2 weeks ago

#29879 new enhancement

Make push branches in a specific order

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-ci, tor-merge-scripts, fast-fix, 041-deferred-20190530
Cc: Actual Points:
Parent ID: Points: 0.1
Reviewer: Sponsor: Sponsor31-can

Description currently pushes all the branches at once. Then GitHub sends requests to build each branch to Travis and Appveyor.

Depending on the exact order of the push and network requests, branches are built in an arbitrary order.

Ideally, we want to push branches in this order:

  • master
    • practracker errors
    • errors that appear when merging backports to a later release
  • maint branches, in order from the earliest release, to the most recent release
    • errors that appear when merging the PR into code that was added after the PR merge was build
  • release branches, in the same order

So we should push branches in a for loop, with a sleep between each branch. On high-latency networks (me!), the sleep might need to be a few seconds long.

Child Tickets

Change History (4)

comment:1 Changed 3 months ago by teor

Sponsor: Sponsor31-can

This issue was partly caused by practracker, marking as Sponsor 31 can.

comment:2 Changed 3 months ago by teor

Keywords: fast-fix added

comment:3 Changed 2 weeks ago by nickm

Keywords: 041-deferred-20190530 added

Marking these tickets as deferred from 041.

comment:4 Changed 2 weeks ago by nickm

Milestone: Tor: 0.4.1.x-finalTor: 0.4.2.x-final
Note: See TracTickets for help on using tickets.