Opened 6 months ago

Closed 6 months ago

#29882 closed defect (fixed)

Make practracker produce output in a stable order

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: asn-merge, tor-ci
Cc: Actual Points: 0
Parent ID: #29880 Points: .1
Reviewer: teor Sponsor:

Description

It looks like practracker produces different output based on the OS directory traversal order.

Two directories on my macOS machine produce the same file, but with a different line order to the one in git. See the resulting commit here:
https://github.com/torproject/tor/pull/837/commits/973451edd1a8f0fe7c07ae5ba7fe8256ef279f95

If we want to automate practracker, we'll need to use a stable sort order for warnings.

Child Tickets

Change History (7)

comment:1 Changed 6 months ago by nickm

Owner: set to nickm
Points: .1
Status: newaccepted

comment:2 Changed 6 months ago by nickm

Actual Points: 0
Status: acceptedneeds_review

Easy one -- branch is practracker_sort with PR at https://github.com/torproject/tor/pull/839

comment:3 Changed 6 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.4.1.x-final

comment:4 Changed 6 months ago by asn

Reviewer: teor

comment:5 Changed 6 months ago by teor

Status: needs_reviewmerge_ready

Looks fine to me.

Let's decide what to do about the existing exceptions file in one of the other tickets.

comment:6 Changed 6 months ago by teor

Keywords: asn-merge added; 042-must tor-merge-scripts removed

comment:7 Changed 6 months ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.