Opened 19 months ago

Last modified 14 months ago

#29886 new defect

NoScript icon is still visible in context menu after the fix for #25658 landed

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: GeorgKoppen201812, tbb-8.5, TorBrowserTeam201906
Cc: tbb-team, dmr, isnaiter, arthuredelstein, mcs, brade Actual Points:
Parent ID: #25658 Points:
Reviewer: Sponsor:

Description

A user on the blog noticed that we removed the NoScript toolbar icon but the one in the context menu is still visible. (see: https://blog.torproject.org/comment/280411#comment-280411). Moreover, clicking on it results in an error:

TypeError: this.getPlacementOfWidget(...) is null[Learn More]  CustomizableUI.jsm:1638:18

Child Tickets

Change History (5)

comment:1 Changed 19 months ago by gk

Keywords: TorBrowserTeam201904 added; TorBrowserTeam201903 removed

Moving tickets to April.

comment:2 Changed 18 months ago by gk

Keywords: TorBrowserTeam201905 added; TorBrowserTeam201904 removed

Moving tickets to May

comment:3 Changed 17 months ago by cyberpunks

Instead of the issue being that it's visible in context menu, I think the real issue is there's no way to edit per site JS. I know this is an advanced feature but I think allowing people to right click and whitelist specific sites in Safest Mode is useful.

For example, someone with an anonymous Reddit may trust the Reddit site to run JS, but not the bunch of sites Reddit links to. The "safer" mode isn't workable for this user, but safest breaks functionality.

comment:4 Changed 17 months ago by gk

Keywords: TorBrowserTeam201906 added; TorBrowserTeam201905 removed

Moving tickets to June

comment:5 Changed 14 months ago by pili

Keywords: ux-team removed
Note: See TracTickets for help on using tickets.