Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#29894 closed defect (fixed)

Initial split-up on control.c

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: asn-merge
Cc: Actual Points: 1
Parent ID: #29210 Points:
Reviewer: ahf Sponsor: Sponsor31-can

Description

As a first step to refactoring control.c, let's split it up.

Child Tickets

Change History (5)

comment:1 Changed 6 months ago by nickm

Reviewer: ahf
Status: assignedneeds_review

See branch split_control with PR in https://github.com/torproject/tor/pull/842.

There should be no meaningful code changes here -- just a lot of movement. I recommend reviewing the branch with "git --color-moved".

comment:2 Changed 6 months ago by ahf

Status: needs_reviewmerge_ready

This looks good, the color moved part certainly makes it easier to review these things. Think it would have been impossible without it or need lots of scripting.

CI also seems happy.

comment:3 Changed 6 months ago by nickm

Keywords: asn-merge added

comment:4 Changed 6 months ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged to master.

comment:5 Changed 6 months ago by nickm

Sponsor: Sponsor31-can
Note: See TracTickets for help on using tickets.