Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#29896 closed enhancement (duplicate)

Backport connection_dir_buf_add() to 0.3.4 and later

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-dirauth, metrics-needs, tor-bwauth, 035-removed-20180711, 040-roadmap-proposed
Cc: starlight@… Actual Points: 0.1
Parent ID: #21377 Points: 0.1
Reviewer: Sponsor:

Description

We need connection_dir_buf_add() in 0.3.4 for #21377.

But I don't want to backport all the refactoring, just the new function.

Child Tickets

Change History (3)

comment:1 Changed 5 months ago by teor

Actual Points: 0.1
Keywords: 034-backport removed
Points: 0.1
Status: assignedneeds_review

We won't be backporting to 0.3.4, because #21377 doesn't rebase cleanly to 0.3.4.

I cherry-picked the commits for the new function and changes file from https://github.com/torproject/tor/pull/696 in #28816. But I didn't take the refactoring commit.

Here are the pull requests:

#28816 has already been reviewed by 2 people, and it's been in nightly for 4 weeks. So I could backport this change as soon as CI has passed.

But I think we should just cherry-pick the commits on to the branch in #29897, before doing the refactor.

comment:2 Changed 5 months ago by teor

Resolution: duplicate
Status: needs_reviewclosed

We'll handle this in #29897.

comment:3 Changed 5 months ago by teor

Keywords: 035-backport 040-backport removed

Remove backport tags.

Note: See TracTickets for help on using tickets.