Opened 7 months ago

Closed 7 months ago

#29926 closed defect (fixed)

shellcheck: asciidoc-helper.sh issues

Reported by: rl1987 Owned by: rl1987
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: catalyst Sponsor: Sponsor31-can

Description

In doc/asciidoc-helper.sh line 22:
      TZ=UTC "$2" -d manpage -o $output $input;
                                ^-----^ SC2086: Double quote to prevent globbing and word splitting.
                                        ^----^ SC2086: Double quote to prevent globbing and word splitting.


In doc/asciidoc-helper.sh line 47:
    if "$2" -f manpage $input; then
                       ^----^ SC2086: Double quote to prevent globbing and word splitting.


In doc/asciidoc-helper.sh line 48:
      mv $base.1 $output;
         ^---^ SC2086: Double quote to prevent globbing and word splitting.
                 ^-----^ SC2086: Double quote to prevent globbing and word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

Child Tickets

Change History (9)

comment:1 Changed 7 months ago by rl1987

Status: newneeds_review

comment:2 Changed 7 months ago by rl1987

Owner: set to rl1987
Status: needs_reviewaccepted

comment:3 Changed 7 months ago by rl1987

Status: acceptedneeds_review

comment:4 Changed 7 months ago by asn

Reviewer: mikeperry

comment:5 Changed 7 months ago by teor

Reviewer: mikeperry

Remove Mike as reviewer, because he's overloaded.
We'll work out what to do with these tickets in the weekly meeting.

comment:6 Changed 7 months ago by teor

Milestone: Tor: 0.4.1.x-final

comment:7 Changed 7 months ago by asn

Reviewer: catalyst

comment:8 in reply to:  1 Changed 7 months ago by catalyst

Status: needs_reviewmerge_ready

Replying to rl1987:

https://github.com/torproject/tor/pull/862

Thanks! Looks good!

comment:9 Changed 7 months ago by teor

Actual Points: 0.1
Points: 0.1
Resolution: fixed
Sponsor: Sponsor31-can
Status: merge_readyclosed

Looks like best practices support to me, so it can be Sponsor 31.

Merged to master.

Merged #29121, #30004 to 0.4.0, and #29926, #28806 to master, then merged forward.

Note: See TracTickets for help on using tickets.