Opened 8 months ago

Closed 8 months ago

#29938 closed defect (fixed)

pubsub: coverity sees a null pointer deref in lint_message_consistency (CID 1444257)

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords:
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: catalyst Sponsor: Sponsor31-can

Description

Coverity thinks that lint_message_consistency could have a null pointer dereference. It can't, actually, but the reasoning why it can't is too complicated. We should fix things so that Coverity isn't confused.

Child Tickets

Change History (5)

comment:1 Changed 8 months ago by nickm

Simple fix in my branch bug29938; PR at https://github.com/torproject/tor/pull/863

comment:2 Changed 8 months ago by nickm

Status: assignedneeds_review

comment:3 Changed 8 months ago by asn

Reviewer: catalyst

comment:4 in reply to:  1 Changed 8 months ago by catalyst

Status: needs_reviewmerge_ready

Replying to nickm:

Simple fix in my branch bug29938; PR at https://github.com/torproject/tor/pull/863

Looks good! Thanks!

comment:5 Changed 8 months ago by teor

Points: 0.1
Resolution: fixed
Status: merge_readyclosed
Version: Tor: unspecified

Merged to master.

Note: See TracTickets for help on using tickets.