Opened 6 months ago

Closed 6 months ago

#29939 closed defect (fixed)

test_routerkeys: Coverity says, always check mkdir return values.

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: asn-merge, coverity
Cc: Actual Points: 0
Parent ID: Points: 0
Reviewer: ahf Sponsor:

Description

There's a new coverity warning about checking the return values from mkdir() in test_routerkeys.c. That's odd, since we've had this code since 0.2.7.2-alpha. But we may as well check it. This is CID 1444254.

I say this is not a backport candidate, since it only affects the tests.

Child Tickets

Change History (8)

comment:1 Changed 6 months ago by nickm

Actual Points: 0
Status: newneeds_review

Fix in branch bug29939; PR at https://github.com/torproject/tor/pull/864 .

I've also verified that we have no other unchecked calls to mkdir.

comment:2 Changed 6 months ago by asn

Reviewer: ahf

comment:3 Changed 6 months ago by ahf

Status: needs_reviewmerge_ready

Looks good.

comment:4 Changed 6 months ago by nickm

Keywords: asn-merge added

comment:5 Changed 6 months ago by teor

Owner: set to nickm
Status: merge_readyassigned

comment:6 Changed 6 months ago by teor

Status: assignedmerge_ready

comment:7 in reply to:  description Changed 6 months ago by teor

Replying to nickm:

I say this is not a backport candidate, since it only affects the tests.

I agree: the impact of this change is that we get slightly more accurate test failure info if test setup fails.

comment:8 Changed 6 months ago by teor

Keywords: coverity added
Resolution: fixed
Status: merge_readyclosed
Version: Tor: unspecified

#29939 and #29967 merged to master after the merge-forward of #29703 (which only changed 0.2.9).

Note: See TracTickets for help on using tickets.