#29943 closed defect (fixed)

Adapt Torbutton to AB_CD -> AB-CD changes for our locales

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton, tbb-8.5-must-alpha, TorBrowserTeam201904R, GeorgKoppen201904
Cc: emmapeel Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Over in #29844 we moved our locales that followed the AB_CD convention over to those that use the AB-CD one which is Mozilla using as well.

We now need to add those locales and remove the old ones and adapt our translations import script.

Child Tickets

Change History (7)

comment:1 Changed 19 months ago by gk

Keywords: TorBrowserTeam201903 GeorgKoppen201903 added

comment:2 Changed 19 months ago by gk

Keywords: GeorgKoppen201903R added; GeorgKoppen201903 removed
Status: newneeds_review

Okay, I tested all the affected locales and found no issues. Here is the patch for review: bug_29943 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_29943&id=ad0f608cba44dc8be382b380b844cfd66dedecba) in my torbutton repository.

comment:3 Changed 19 months ago by gk

Keywords: TorBrowserTeam201903R GeorgKoppen201903 added; TorBrowserTeam201903 GeorgKoppen201903R removed

comment:4 Changed 19 months ago by gk

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201903R removed

Moving review tickets to April.

comment:5 Changed 19 months ago by gk

Keywords: GeorgKoppen201904 added; GeorgKoppen201903 removed

Moving my tickets for April

comment:6 Changed 19 months ago by mcs

r=brade, r=mcs
Looks good.

comment:7 in reply to:  6 Changed 19 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to mcs:

r=brade, r=mcs
Looks good.

Thanks! Merged to master (commit 76d056634148add263720504aa4c6ff0c480165a)

Note: See TracTickets for help on using tickets.