Opened 9 months ago

Closed 3 months ago

#29955 closed task (fixed)

Final Orfox update

Reported by: sysrqb Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ux-team, tbb-mobile, tbb-8.5, TorBrowserTeam201909
Cc: igt0, gk, n8fr8, eighthave, steph, emmapeel Actual Points:
Parent ID: #27399 Points:
Reviewer: Sponsor:

Description

I'm debating how we should do this. Ideally, we want to migrate all Orfox users to TBA. In this ideal world, I would propose creating a very simple app as a replacement for Orfox where this new app simply says something like "Orfox is now Tor Browser for Android! Please install it from <app store link>". We can detect if the device has the Play store or F-droid installed and give the user one of the links. We can also offer a way to migrate the users bookmarks from Orfox to TBA.

The real world is more complicated than the ideal world. I worry about releasing an update of Orfox that completely replaces its current functionality with a simple-migration-tool. However, realistically, no one should be using Firefox 52esr now, so moving users away from that is important. With that being said, people should have a choice.

One problem is we can't easily release a new version of Orfox (based on 52esr) because Google Play won't accept it due to stricter requirements that went into effect last October. Therefore, we are in a not so great situation with this.

Child Tickets

TicketStatusOwnerSummaryComponent
#31351closedemmapeellocalization orfoxRIPApplications/Tor Browser

Attachments (3)

Orfox Update.png (53.2 KB) - added by antonela 7 months ago.
Orfox Download.png (53.1 KB) - added by antonela 7 months ago.
Orfox Download.2.png (51.0 KB) - added by antonela 7 months ago.

Download all attachments as: .zip

Change History (45)

comment:1 Changed 9 months ago by sysrqb

Cc: n8fr8 eighthave added

comment:2 Changed 9 months ago by sysrqb

I guess another option is we release one final Orfox version based on 60esr using the current TBA patches except we don't include the patches integrating Orbot directly in the app. We then add a screen (similar to the onboarding screens) containing the migration information for TBA. This option won't be without risks, too.

comment:3 Changed 9 months ago by gk

Keywords: TBA-8.5 removed

comment:4 Changed 9 months ago by gk

I remember n8fr8 had some ideas back then in Mexico although I don't remember exactly what they were. Maybe those could help here finding a good solution?

comment:5 Changed 8 months ago by gk

Keywords: TorBrowserTeam201904 added; TorBrowserTeam201903 removed

Moving tickets to April.

comment:6 Changed 8 months ago by n8fr8

One problem is we can't easily release a new version of Orfox (based on 52esr) because Google Play >won't accept it due to stricter requirements that went into effect last October. Therefore, we are in a >not so great situation with this.

What are the stricter requirements? Related to SDK version?

Considering all the limitations we have with supporting old code, I am happy to replace the current app with a very simple "You must upgrade, go here" type app. We can offer both a link to Google Play, F-Droid, and to a direct APK download.

comment:7 Changed 8 months ago by n8fr8

Also, btw, we can include a notice in Orbot, since we will be removing the link to Orfox there. We can add a message about why you don't need Orbot for TBA, etc.

comment:8 in reply to:  6 Changed 8 months ago by sysrqb

Replying to n8fr8:

One problem is we can't easily release a new version of Orfox (based on 52esr) because Google Play >won't accept it due to stricter requirements that went into effect last October. Therefore, we are in a >not so great situation with this.

What are the stricter requirements? Related to SDK version?

Yes, that is the primary problem I know about.

Considering all the limitations we have with supporting old code, I am happy to replace the current app with a very simple "You must upgrade, go here" type app. We can offer both a link to Google Play, F-Droid, and to a direct APK download.

Great, yes, that is what I was thinking.

Replying to n8fr8:

Also, btw, we can include a notice in Orbot, since we will be removing the link to Orfox there. We can add a message about why you don't need Orbot for TBA, etc.

That would be awesome, thanks.

comment:9 Changed 8 months ago by n8fr8

What should we target as a date for this?

comment:10 Changed 8 months ago by gk

Keywords: tbb-8.5 added; tbb-8.5-must removed

Not strictly needed before we get 8.5 out.

comment:11 in reply to:  9 Changed 8 months ago by gk

Replying to n8fr8:

What should we target as a date for this?

We hope to get 8.5 built next week. So, I guess we would get it out early the week after, which would be a good target date.

comment:12 Changed 7 months ago by gk

Keywords: TorBrowserTeam201905 added; TorBrowserTeam201904 removed

Moving tickets to May

Changed 7 months ago by antonela

Attachment: Orfox Update.png added

Changed 7 months ago by antonela

Attachment: Orfox Download.png added

comment:13 Changed 7 months ago by antonela

Hi! Is not clear to me what is better/doable. If Orfox users can update Orfox and get Tor Browser, that'd be ideal. If not we can offer them to download from the options we have.
I made mockups for both scenarios, to have in Orfox.
We need Steph's review on this. *Somewhere* we should say that you don't need two apps for browsing anymore.

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29955/Orfox%20Update.png https://trac.torproject.org/projects/tor/raw-attachment/ticket/29955/Orfox%20Download.png

comment:14 Changed 7 months ago by antonela

Cc: steph added

comment:15 in reply to:  13 Changed 7 months ago by sysrqb

Replying to antonela:

Hi! Is not clear to me what is better/doable. If Orfox users can update Orfox and get Tor Browser, that'd be ideal. If not we can offer them to download from the options we have.
I made mockups for both scenarios, to have in Orfox.
We need Steph's review on this. *Somewhere* we should say that you don't need two apps for browsing anymore.

These look so good! Thanks! Unfortunately users can't upgrade directly from Orfox to Tor Browser, so they must go through these steps (install new app and uninstall orfox).

I think we can say "Orfox is now Tor Browser", and we can gives users the F-Droid button if they currently have F-Droid installed, and similar for Google Play. Downloading directly from the website is a little risky, but I'm not totally against it. If we include this option, then we'll need additional verification added into the orfox update (verifying the signature is valid), but it's possible.

comment:16 Changed 7 months ago by steph

They both look great! I think if the 2nd version is used (I like the idea of showing the options), I would just suggest the language be "Get the update from your preferred source:"

Also, I think we decided that we no longer needed to say "for Android." So that could just be "Try Tor Browser"

So it'd be:

Try Tor Browser
Orfox is now Tor Browser.
Get it from your preferred source:

comment:17 Changed 7 months ago by n8fr8

Cool. Thanks for all this. I think having all 3 options is fine and necessary.

comment:18 Changed 7 months ago by n8fr8

Could you make a squished Orfox underneath the new icon?

"Orfox is dead! Long Live Tor Browser!"

Changed 7 months ago by antonela

Attachment: Orfox Download.2.png added

comment:19 in reply to:  18 Changed 7 months ago by antonela

Replying to steph:

Try Tor Browser
Orfox is now Tor Browser.
Get it from your preferred source:

Perfect!

https://trac.torproject.org/projects/tor/raw-attachment/ticket/29955/Orfox%20Download.2.png

comment:20 Changed 7 months ago by antonela

Replying to n8fr8:

Could you make a squished Orfox underneath the new icon?
"Orfox is dead! Long Live Tor Browser!"

XD

I synced it here so you can grab the assets. Please, let me know if anything else is needed.
https://marvelapp.com/33d23hc/screen/56744451/handoff

We need some localized strings for this. Should we bring emmapeel to the party?

comment:21 Changed 7 months ago by n8fr8

Sure. I guess I will be implement this here: https://github.com/guardianproject/orfox

so once it is up, and there are string files to localize we can do that.

comment:22 Changed 7 months ago by n8fr8

@sysrqb can you provide all the official links I should use?

@antonela I think after you click, maybe we should show a screen that says "You can/should uninstall Orfox as you don't need it anymore", and then after a few seconds open the link to TBA.

comment:23 in reply to:  21 Changed 7 months ago by sysrqb

Replying to n8fr8:

Sure. I guess I will be implement this here: https://github.com/guardianproject/orfox

Thanks! I tried pinging you on irc, i didn't realize you'd be able to implement this (I assumed it would be on us) - but I'd love the help if you have the cycles for it! So, thank you (really really)!

comment:24 in reply to:  22 Changed 7 months ago by sysrqb

Replying to n8fr8:

@sysrqb can you provide all the official links I should use?

The Android section has the link for Google Play - https://www.torproject.org/download/#android

https://play.google.com/store/apps/details?id=org.torproject.torbrowser_alpha

I'll pick up deploying it on f-droid again - I dropped it for a bit. Currently, we're still using your f-droid repo, but it'd be awesome if we can include an official f-droid.org link in this release.

comment:25 Changed 7 months ago by n8fr8

Actually, I think there is a link format that can open either Play or F-Droid for the same package id. We can autodetect if they have F-Droid installed, and only show that if they do... something to talk to _hc about.

Will get on irc.

comment:26 Changed 7 months ago by eighthave

It is easy to reliably detect whether Google Play and/or F-Droid is installed, so the UI should only show options that make sense based on that info. E.g. only show Play or F-Droid buttons if they are installed. The open case is what to do if neither Play nor F-Droid is detected. There could be a market: link, which in theory should open in any app store, but I think it is unevenly implemented. My guess is that the direct APK download option probably makes more sense.

As for building this final release, I think it should not be a full Orfox build. It should only be a tiny shim app to walk the user through installing Tor Browser.

This shim app can use the same logic for detecting Play/F-Droid to detect if Tor Browser is installed. If it is installed, I think the Orfox shim should prompt the user to uninstall itself. That's also very easy to do.

comment:27 Changed 7 months ago by eighthave

We should also get those strings up on webalte/transifex ASAP so the translators have time to translate. I imagine that we will want to wait until the translations are complete for the languages that Orfox users use most.

comment:28 Changed 6 months ago by gk

Keywords: TorBrowserTeam201906 added; TorBrowserTeam201905 removed

Moving tickets to June

comment:29 Changed 5 months ago by gk

Keywords: TorBrowserTeam201907 added; TorBrowserTeam201906 removed

Moving tickets to July

comment:30 Changed 5 months ago by n8fr8

@gk @sysrqb any progress on implementing the code / UI? We need to get this done in July, as Orfox is not 64-bit, and will be removed from Google Play August 1, I believe.

comment:31 Changed 5 months ago by eighthave

As far as I understand the Google Play requirement, it only applies to APKs that are being uploaded after August 1st. APKs that are already in Google Play won't be kicked out.
https://android-developers.googleblog.com/2019/01/get-your-apps-ready-for-64-bit.html

comment:32 in reply to:  30 Changed 5 months ago by gk

Replying to n8fr8:

@gk @sysrqb any progress on implementing the code / UI? We need to get this done in July, as Orfox is not 64-bit, and will be removed from Google Play August 1, I believe.

What do you mean? In comment:21 and comment:22 you said you would implement the final Orfox transition. Or did I misunderstand you here?

comment:33 Changed 5 months ago by n8fr8

Ah I did, didn't I! :) Sorry, cross wires in my head. I thought somehow that it landed back on your teams plate.

I will crank this our on my way to Sweden, and maybe we can fast track the translations for our top languages at least, and get it launched.

comment:34 in reply to:  33 Changed 5 months ago by gk

Replying to n8fr8:

Ah I did, didn't I! :) Sorry, cross wires in my head. I thought somehow that it landed back on your teams plate.

I will crank this our on my way to Sweden, and maybe we can fast track the translations for our top languages at least, and get it launched.

Sounds good, thanks!

comment:35 Changed 5 months ago by n8fr8

I've implemented the OrfoxRIP migration app and pushed it here as the default branch:
https://github.com/guardianproject/Orfox

The GPlay click opens Google Play to the TBA listing.

The Fdroid link opens to the guardianproject repo.

The APK link opens to the torproject.org download link/page.

We just need to localize the few strings and we are ready to go!

comment:36 in reply to:  35 Changed 5 months ago by gk

Cc: emmapeel added

Replying to n8fr8:

I've implemented the OrfoxRIP migration app and pushed it here as the default branch:
https://github.com/guardianproject/Orfox

The GPlay click opens Google Play to the TBA listing.

The Fdroid link opens to the guardianproject repo.

The APK link opens to the torproject.org download link/page.

We just need to localize the few strings and we are ready to go!

Nice! emmapeel: how could we move forward with that? Or is this handled by the Guardian Project, n8fr8?

comment:37 Changed 5 months ago by eighthave

Given that @n8fr8 and I have too many things going on at the moment, and aren't specifically funded to work on Tor Browse things, I think it makes sense for Tor Project to handle this. Then one of us can publish the result to Play and F-Droid. For example, that OrfoxRIP app needs to be translated.

comment:38 Changed 5 months ago by pili

Just so I understand where we are at and what needs to happen next:

  1. @n8fr8 has implemented the migration app
  2. Tor Project should coordinate localisation of migration app
  3. Once localisation is done, Guardian Project will build migration app
  4. Guardian Project will sign migration app
  5. Guardian Project will publish migration app

Is there anything else other than localisation that Tor Project should do? I can coordinate these items from Tor Project side

comment:39 Changed 4 months ago by n8fr8

APK build with the localizations now available here:
https://github.com/guardianproject/Orfox/releases/tag/Orfox-Final-RIP-v16

This has the same package id and is signed with same release key as the Orfox browser app, so you can test installing this over the last release of that ( from Google Play or https://github.com/guardianproject/Orfox/releases/tag/Fennec-52.9.0esr%2FTorBrowser-7.5-1%2FOrfox-1.5.4-RC-1 )

comment:40 Changed 4 months ago by gk

Keywords: TorBrowserTeam201908 added; TorBrowserTeam201907 removed

Moving more tickets to August

comment:41 Changed 3 months ago by gk

Keywords: TorBrowserTeam201909 added; TorBrowserTeam201908 removed

Moving tickets to September

comment:42 Changed 3 months ago by sysrqb

Resolution: fixed
Status: newclosed

This is completed! Some users are sad, as expected :(

Note: See TracTickets for help on using tickets.