Opened 9 months ago

Closed 9 months ago

#29971 closed defect (fixed)

obfs4 fails to build in nightly builds

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201903R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The build of obfs4 fails to build with the following error:

Starting build: Sun Mar 31 01:47:41 2019
# gitlab.com/yawning/obfs4.git/transports/meeklite
/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/transports/meeklite/transport.go:51:29: undefined: "gitlab.com/yawning/utls.git".HelloFirefox_65
/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/transports/meeklite/transport.go:56:29: undefined: "gitlab.com/yawning/utls.git".HelloChrome_72
/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/transports/meeklite/transport.go:59:29: undefined: "gitlab.com/yawning/utls.git".HelloIOS_12_1
/var/tmp/dist/gopath/src/gitlab.com/yawning/obfs4.git/transports/meeklite/transport.go:248:2: undefined: "gitlab.com/yawning/utls.git".EnableVartimeAES

This is probably fixed by updating the utls tag.

Child Tickets

Change History (5)

comment:1 Changed 9 months ago by boklm

Keywords: TorBrowserTeam201903R added; TorBrowserTeam201903 removed
Status: newneeds_review

comment:2 Changed 9 months ago by yawning

Whoops, sorry, forgot to give a heads up when I did that. Yes that looks fine.

At some point I'm thinking of tagging 0.0.10 because it has a pile of utls related fixes (upstream, in my fork, and to the transport)...

comment:3 in reply to:  1 Changed 9 months ago by gk

Replying to boklm:

There is a patch for review in branch bug_29971_v2:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_29971_v2&id=b5401882cfed17d6259d74a20739a811b73976ba

I think are usually doing something like version: '[% c("abbrev") %]' in case we don't have a tag we can build from but provide a sha1 commit hash. Why are we doing here

+version: 0.0.0
+git_hash: 26d1add596b6d800bdeeb3bc3b2c7b316c056b6d

instead?
`

comment:4 Changed 9 months ago by boklm

Ah, yes, having the commit in the output filename would be better than 0.0.0 (although var/build_id is already changing when the commit is changing), so I changed that in branch bug_29971_v3:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_29971_v3&id=893a4825b1a430ef955812248ebba8017a5c05d7

comment:5 Changed 9 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Merged to master (commit 893a4825b1a430ef955812248ebba8017a5c05d7).

Note: See TracTickets for help on using tickets.