Opened 7 weeks ago

Closed 7 weeks ago

#29973 closed defect (fixed)

Remove remaining stopOpenSecuritySettingsObserver() pieces

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ux-team, GeorgKoppen201904, TorBrowserTeam201904, tbb-8.5-must-alpha
Cc: tbb-team, dmr, isnaiter, arthuredelstein, mcs, brade Actual Points:
Parent ID: #25658 Points:
Reviewer: Sponsor:

Description

stopOpenSecuritySettingsObserver() is not needed anymore with the changes in #25658. However, there are some pieces left of it that result in a browser console error. Noted on our blog: https://blog.torproject.org/comment/280343#comment-280343

Child Tickets

Change History (3)

comment:1 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201904R added; TorBrowserTeam201904 removed
Status: newneeds_review

comment:2 Changed 7 weeks ago by pospeselr

Keywords: TorBrowserTeam201904 added; TorBrowserTeam201904R removed
Status: needs_reviewmerge_ready

Looks good to me.

comment:3 Changed 7 weeks ago by gk

Resolution: fixed
Status: merge_readyclosed

Thanks. Merged to master (commit 409f01d42ffb9efc85c9245f9baa6ea1831003c2).

Note: See TracTickets for help on using tickets.