Opened 5 months ago

Closed 2 months ago

#29976 closed task (fixed)

rework bootstrap reporting to use pubsub

Reported by: catalyst Owned by: catalyst
Priority: Medium Milestone: Tor: 0.4.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: bootstrap network-team-roadmap-2019-Q1Q2, dgoulet-merge
Cc: Actual Points: 5
Parent ID: Points:
Reviewer: nickm Sponsor: Sponsor19

Description


Child Tickets

Change History (15)

comment:3 Changed 3 months ago by catalyst

Status: assignedneeds_review

comment:4 Changed 3 months ago by gaba

Keywords: network-team-roadmap-2019-Q1Q2 added

comment:5 Changed 3 months ago by catalyst

Actual Points: 5
Parent ID: #27104

comment:6 Changed 3 months ago by dgoulet

Reviewer: nickm

comment:7 Changed 3 months ago by nickm

Status: needs_reviewneeds_revision

I left a few questions/comments on github. Otherwise, this looks good to me.

comment:8 in reply to:  7 ; Changed 3 months ago by catalyst

Status: needs_revisionneeds_review

Replying to nickm:

I left a few questions/comments on github. Otherwise, this looks good to me.

Thanks! I responded to the comment about channels, and pushed a couple of fixup commits for the copy vs pointer assignment issue.

comment:9 in reply to:  8 Changed 3 months ago by catalyst

Replying to catalyst:

Replying to nickm:

I left a few questions/comments on github. Otherwise, this looks good to me.

Thanks! I responded to the comment about channels, and pushed a couple of fixup commits for the copy vs pointer assignment issue.

Travis error is a spurious failure from test_rebind.sh.

comment:10 Changed 3 months ago by nickm

Milestone: Tor: unspecifiedsbws: 2.0.x-final

comment:11 Changed 3 months ago by teor

Milestone: sbws: 2.0.x-finalTor: 0.4.2.x-final

comment:14 Changed 3 months ago by nickm

oh no, wrong ticket. Deleted spurious link I just added.

Last edited 3 months ago by nickm (previous) (diff)

comment:15 Changed 3 months ago by nickm

Status: needs_reviewmerge_ready

This LGTM now. Let's merge it once 0.4.2 is open.

comment:16 Changed 2 months ago by nickm

Keywords: dgoulet-merge added

comment:17 Changed 2 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Merged to 042!

Note: See TracTickets for help on using tickets.