Opened 7 months ago

Closed 7 months ago

#29979 closed defect (fixed)

Don't recommend expect() in CodingStandardsRust, because it panics

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy, doc, asn-merge, nickm-merge
Cc: Actual Points: 0.1
Parent ID: #27207 Points: 0.1
Reviewer: teor Sponsor:

Description (last modified by teor)

See the pull request from a GitHub contributor:
https://github.com/torproject/tor/pull/883

Child Tickets

Change History (6)

comment:1 Changed 7 months ago by teor

Status: newneeds_revision

I have reviewed the pull request and suggested changes

comment:2 Changed 7 months ago by teor

Reviewer: teor

comment:3 Changed 7 months ago by teor

Actual Points: 0.1
Description: modified (diff)
Keywords: asn-merge nickm-merge added
Points: 0.1
Status: needs_revisionmerge_ready

Looks good to me!

comment:4 Changed 7 months ago by teor

(We'll need to squash this branch before it merges.)

comment:5 Changed 7 months ago by teor

Parent ID: #27207

This ticket fixes some of the bugs in #27207

comment:6 Changed 7 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

squashed and merged to master!

Note: See TracTickets for help on using tickets.