Opened 6 months ago

Closed 5 months ago

#29984 closed defect (fixed)

Controller protocol parser can't find empty initial line

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: .1
Parent ID: #30091 Points:
Reviewer: catalyst Sponsor: Sponsor31-can

Description (last modified by nickm)

We've apparently run into this in a few places before: The code in control.c that extracts the command from the command line will discard the rest of the line too, if the line is empty.

This means that the control.c code can't distinguish these cases:

+FOO A
B 
C
.

and

+FOO
A
B
C

Child Tickets

Change History (5)

comment:1 Changed 6 months ago by nickm

Description: modified (diff)

comment:2 Changed 6 months ago by nickm

Actual Points: .1

comment:3 Changed 5 months ago by nickm

Parent ID: #30091
Reviewer: catalyst
Status: assignedneeds_review

(this is part of #30091. I argue for 'no backport' since it isn't hurting anything for now.)

comment:4 Changed 5 months ago by catalyst

Status: needs_reviewmerge_ready

Covered by parent pull request

comment:5 Changed 5 months ago by dgoulet

Resolution: fixed
Status: merge_readyclosed

Parent merged.

Note: See TracTickets for help on using tickets.