Opened 3 months ago

Closed 2 months ago

#30001 closed defect (fixed)

test failure: dir_handle_get/status_vote_next_bandwidth

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version: Tor: 0.4.0.4-rc
Severity: Normal Keywords: tor-ci-fail-sometimes, fast-fix, 040-backport, reviewer-was-teor-20190422, asn-merge
Cc: teor, juga Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

Found by travis: https://travis-ci.org/torproject/tor/jobs/515199996

dir_handle_get/status_vote_next_bandwidth: 
  FAIL src/test/test_dir_handle_get.c:2535: assert(strstr(header, expires))
  [status_vote_next_bandwidth FAILED]

To me this looks like a race condition: the clock probably has advanced by a second between the call to directory_handle_command_get() and the call to time(NULL).

Child Tickets

Change History (14)

comment:1 Changed 3 months ago by nickm

Parent ID: #21377

Tentatively setting parent.

comment:2 Changed 3 months ago by nickm

Actual Points: 0.1
Cc: teor juga added
Keywords: fast-fix added
Status: assignedneeds_review

See branch bug30001_040 with PR in https://github.com/torproject/tor/pull/886

comment:3 Changed 3 months ago by teor

Keywords: 040-backport 035-backport-maybe added
Points: 0.1
Status: needs_reviewneeds_revision

#21377 is based on maint-0.3.5, so this fix also needs to be based on 0.3.5.
(We don't normally backport features to stable releases, but metrics might tell us that we need to backport this feature to get bwauth statistics.)

comment:4 Changed 2 months ago by teor

Keywords: tor-ci-fail-sometimes added
Owner: changed from nickm to teor
Reviewer: nickm
Status: needs_revisionassigned
Version: Tor: 0.4.0.4-rc

Hi Nick, I'm going to revise this CI failure ticket today, so we can get it merged.
I think I'll also need to update the changes file, because we released this bug in 0.4.0.4-rc.

comment:5 Changed 2 months ago by teor

Status: assignedneeds_revision

comment:6 Changed 2 months ago by teor

I didn't get to this ticket today, I'll do my revisions first thing tomorrow.

comment:7 Changed 2 months ago by teor

Parent ID: #21377

Un-parenting from #21377, so I can close #21377.

comment:8 Changed 2 months ago by teor

Owner: changed from teor to nickm
Reviewer: nickmteor
Status: needs_revisionassigned

I changed my mind and closed #21377 as no-backport.

comment:9 Changed 2 months ago by teor

See my pull requests with an extra changes entry:

PR 886 failed due to #29036, which is now fixed in all supported branches.

comment:10 Changed 2 months ago by teor

Status: assignedmerge_ready

comment:11 Changed 2 months ago by teor

Keywords: 035-backport-maybe removed

comment:12 Changed 2 months ago by teor

Keywords: reviewer-was-teor-20190422 added
Reviewer: teor

If these tickets go back in to needs_review, and I am on leave, they will need another reviewer.

comment:13 Changed 2 months ago by nickm

Keywords: asn-merge added

comment:14 Changed 2 months ago by asn

Resolution: fixed
Status: merge_readyclosed

Merged to 040 and onwards.

Note: See TracTickets for help on using tickets.