Opened 7 months ago

Closed 6 months ago

#30008 closed defect (fixed)

Remove unused FIFO copy paste code from snowflake client

Reported by: cohosh Owned by:
Priority: Very Low Milestone:
Component: Circumvention/Snowflake Version:
Severity: Normal Keywords: snowflake
Cc: dcf, arlolra, cohosh Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor19

Description

We are no longer doing ICE signaling manually and so don't need to information to be copy pasted between the terminal and browser.

Child Tickets

Change History (6)

comment:1 Changed 6 months ago by arlolra

Status: newneeds_review

Here's a patch that removes all this copy/paste signalling,
https://github.com/keroserene/snowflake/commit/1c083740142a18f084dc2826793701229468a1c9

comment:2 Changed 6 months ago by cohosh

Looks good to me

Only comment:

  • At rendezvous.go#L8
    //   (This is the recommended default, enabled via the flags in "torrc".)
    
    I suppose this is now the only option as opposed to recommended default. We might want to say it's customizable via the flags in torrc.

comment:3 Changed 6 months ago by arlolra

Thanks. I'll give dcf a bit of time to weigh in before amending the patch with your suggestion and pushing.

comment:4 Changed 6 months ago by dcf

Status: needs_reviewmerge_ready

Okay, works for me.

comment:5 in reply to:  2 Changed 6 months ago by arlolra

Merged as https://gitweb.torproject.org/pluggable-transports/snowflake.git/commit/?id=622005c79ed2e9f444d75dba90b3ee52fdc82a37

Replying to cohosh:

I suppose this is now the only option as opposed to recommended default. We might want to say it's customizable via the flags in torrc.

I just removed the entire parenthetical, since flags are part of the binary and this is in the client library.

comment:6 Changed 6 months ago by arlolra

Resolution: fixed
Status: merge_readyclosed
Note: See TracTickets for help on using tickets.