Opened 8 months ago
Closed 8 months ago
#30016 closed defect (fixed)
Include onboarding/start-up translations in localized builds
Reported by: | gk | Owned by: | tbb-team |
---|---|---|---|
Priority: | Very High | Milestone: | |
Component: | Applications/Tor Browser | Version: | |
Severity: | Normal | Keywords: | tbb-mobile, TorBrowserTeam201904R, GeorgKoppen201904, tbb-8.5-must, tbb-parity |
Cc: | emmapeel, igt0, gk, hans@… | Actual Points: | |
Parent ID: | #26782 | Points: | |
Reviewer: | boklm | Sponsor: |
Description
With #29994 and #30015 done we can try providing localization for everything Tor Browser for Android related as it is contained in the torbrowser_strings.dtd
file. This comprises both onboarding and bootstrap/bridge panel strings.
The idea would be to add that file/those strings per locale during the repacking step in our tor-browser-build
build script.
Child Tickets
Change History (5)
comment:1 Changed 8 months ago by
Priority: | Very Low → Very High |
---|
comment:2 Changed 8 months ago by
Keywords: | TorBrowserTeam201904R added; TorBrowserTeam201904 removed |
---|---|
Status: | new → needs_review |
comment:4 Changed 8 months ago by
Reviewer: | → boklm |
---|
comment:5 Changed 8 months ago by
Resolution: | → fixed |
---|---|
Status: | needs_review → closed |
This looks good to me. I merged it to master with commit 516887a876b9ed5ebb020e8e3723fc09ac2fe3ec
.
Note: See
TracTickets for help on using
tickets.
bug_30016_v2
(https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30016_v2&id=a901b95e48702cba67a5838244a5773a6843e5ba) has a patch for review.